Clean up and renames #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensfr
added
the
backport-needed
jensfr
force-pushed
the
clean-up-and-renames
branch
from
7fe851e
to
f5d774b
Compare
c3d
reviewed
Apr 26, 2021
jensfr
force-pushed
the
clean-up-and-renames
branch
2 times, most recently
from
141d6d6
to
137d031
Compare
|
I pushed another update. The biggest change is that we're now using openshift-sandboxed-containers**-operator** as the namespace. It matches the other openshift operators. |
openshift-ci
bot
added
the
needs-rebase
jensfr
force-pushed
the
clean-up-and-renames
branch
from
137d031
to
07afd1c
Compare
openshift-ci
bot
removed
the
needs-rebase
jensfr
added
the
do-not-merge/hold
jensfr
force-pushed
the
clean-up-and-renames
branch
from
07afd1c
to
e30e1bf
Compare
jensfr
force-pushed
the
clean-up-and-renames
branch
from
e30e1bf
to
2f9b036
Compare
bpradipt
approved these changes
May 3, 2021
Merged
We should adhere to the naming convention in OpenShift and use the default namespace openshift-sandboxed-containers-operator. The same goes for the quay.io user/repository we use. Use the new quay.io/openshift_sandboxed_containers instead of quay.io/isolatedcontainres. This patch does two things: 1. it cleans up README and example files to use the namespace openshift-sandboxed-containers instead of sandboxed-containers-operator-system. 2. use version 1.0 instead of 4.8 I've disabled namespacePrefix in config/default/kustomize.yaml to avoid it to add "-system" to the namespace. This was the only way to make it work since kustomize doesn't allow to leave the name field in the namespace metadata blank. Signed-off-by: Jens Freimann <jfreimann@redhat.com>
update it to match the latest state. When adding support for the sandboxed-containers RHCOS extension we added some fields. Those were missing in depoy.yaml and we are adding them with this patch. Signed-off-by: Jens Freimann <jfreimann@redhat.com>
Since we are now using the RHCOS extension to install sandboxed containers rpms we have no need for the configmap any more. There is no daemon to use it and no payload image to refer to any more. Signed-off-by: Jens Freimann <jfreimann@redhat.com>
jensfr
force-pushed
the
clean-up-and-renames
branch
from
2f9b036
to
0e10359
Compare
|
New changes are detected. LGTM label has been removed. |
c3d
approved these changes
May 4, 2021
|
@c3d: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Apparently I'm not a collaborator. Sill approving, for what it's worth ;-) |
jensfr
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description of the problem which is fixed/What is the use case
use new namespace name and refer to new quay.io repository
We should adhere to the naming convention in OpenShift and use
the default namespace openshift-sandboxed-containers. The same goes for
the quay.io user/repository we use. Use the new
quay.io/openshift_sandboxed_containers instead of
quay.io/isolatedcontainres.
delete example configmap for payload. We don't have a payload any more.
- What I did
This cleans up README and example files to use the namespace
openshift-sandboxed-containers instead of sandboxed-containers-operator-system.
- How to verify it
Follow the README descripton to install/uninstall and make sure all steps work.
- Description for the changelog
Use new namespace openshift-sandboxed-containers and refer to new quay.io organisation quay.io/openshift_sandboxed_containers