Bug 1810725: Fix kube_proxy metrics #118
Conversation
On the rebase to kubernetes 1.17 the metrics were moved to "k8s.io/component-base/metrics/legacyregistry" as part of: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190404-kubernetes-control-plane-metrics-stability.md But we were using the old endpoint which was github.com/prometheus/client_golang/prometheus . This effort is work in progress so I expect to have problems in future rebases, most certainly we won't face issues here on the 1.18 and 1.19 rebases.
|
/retitle Bug 1810725: Fix kube_proxy metrics |
openshift-ci-robot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810725, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
@openshift-cherrypick-robot: An error was encountered searching for bug 1811739 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@juanluisvaladas: This pull request references Bugzilla bug 1810725, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
requested review from
alexanderConstantinescu and
JacobTanenbaum
|
/lgtm |
|
/bugzilla refresh |
|
@nee1esh: This pull request references Bugzilla bug 1810725, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@juanluisvaladas: This pull request references Bugzilla bug 1810725, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, JacobTanenbaum, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
knobunc
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1810725 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #114
/assign juanluisvaladas