New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1810725: Fix kube_proxy metrics #118

Merged

openshift-merge-robot merged 1 commit into openshift:release-4.4 from openshift-cherrypick-robot:cherry-pick-114-to-release-4.4

Mar 12, 2020

Commits on Mar 11, 2020

Fix kube_proxy metrics

On the rebase to kubernetes 1.17 the metrics were moved to
"k8s.io/component-base/metrics/legacyregistry" as part of:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190404-kubernetes-control-plane-metrics-stability.md
But we were using the old endpoint which was
github.com/prometheus/client_golang/prometheus .

This effort is work in progress so I expect to have problems in future
rebases, most certainly we won't face issues here on the 1.18 and 1.19
rebases.

Juan-Luis de Sousa-Valadas Castaño authored and openshift-cherrypick-robot committed Mar 11, 2020