Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1874798: Add NodeInformer to EgressIP #182

Merged
merged 3 commits into from Sep 14, 2020
Merged

[release-4.5] Bug 1874798: Add NodeInformer to EgressIP #182

merged 3 commits into from Sep 14, 2020

Conversation

danielmellado
Copy link
Contributor

@danielmellado danielmellado commented Sep 2, 2020 •
edited

Backport for #171 #175

  • Refactor logic
  • Fix calling nodeInformer in EgressIPManager.
  • Add NodeInformer to EgressIP

@danielmellado
Add NodeInformer to EgressIP
d28e8dc 
Currently, EgressIP falls out to another node if the node isn't pinging.
This commit also adds the ability of doing so by checking the node
status.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
(cherry picked from commit 265e89a)
@danielmellado
Fix calling nodeInformer in EgressIPManager.
eaa2e6b 
This commit adds nodeInformer to the creation of a eim, as previously it
couldn't be instatiated. In addition, it triggers the change of EIP on
the hostsubnet when the node can't be reached.

(cherry picked from commit 82c79ea)
@danielmellado
Refactor logic
470139d 
This commit refactors the logic and extends the external helper
function.

(cherry picked from commit fd82486)
@openshift-ci-robot
Copy link
Contributor

@danielmellado: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Pull request for cherry-pick-171-175-to-release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielmellado danielmellado changed the title Pull request for cherry-pick-171-175-to-release-4.5 [release-4.5] Bug 1874798: Add NodeInformer to EgressIP Sep 2, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Bugzilla bug 1874798, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1859451 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1859451 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1874798: Add NodeInformer to EgressIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 2, 2020
@danielmellado danielmellado mentioned this pull request Sep 2, 2020
Closed
@danielmellado
Copy link
Contributor Author

/retest

1 similar comment
@danielmellado
Copy link
Contributor Author

/retest

@rcarrillocruz
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020
@abhat
Copy link
Contributor

abhat commented Sep 7, 2020

Can you please include a link to the original PR here?

Something to the effect of Backport for #PR

@danielmellado
Copy link
Contributor Author

danielmellado commented Sep 7, 2020 via email

@openshift-ci-robot
Copy link
Contributor

@danielmellado: This pull request references Bugzilla bug 1874798, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1859451 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1859451 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1874798: Add NodeInformer to EgressIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Sep 10, 2020

/lgtm

Thanks!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, knobunc, rcarrillocruz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [knobunc,rcarrillocruz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@eparis
Copy link
Member

eparis commented Sep 10, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@eparis: This pull request references Bugzilla bug 1874798, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1859451 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1859451 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2020
@danielmellado
Copy link
Contributor Author

/retest tide

@openshift-ci-robot
Copy link
Contributor

@danielmellado: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-upgrade
  • /test e2e-gcp
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

Use /test all to run all jobs.

In response to this:

/retest tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6a0d176 into openshift:release-4.5 Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@danielmellado: All pull requests linked via external trackers have merged:

Bugzilla bug 1874798 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1874798: Add NodeInformer to EgressIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@squeed squeed Awaiting requested review from squeed

Assignees

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@danielmellado @openshift-ci-robot @rcarrillocruz @abhat @knobunc @eparis @openshift-bot @openshift-merge-robot