Make binaries not stripped #221

juanluisvaladas · 2020-11-13T16:02:49Z

By explicitly defining ldflags we remove the -s flag making the binary
produced by the compiler not stripped.

By explicitly defining ldflags we remove the -s flag making the binary produced by the compiler not stripped.

juanluisvaladas · 2020-11-13T16:04:42Z

$ make
go build -mod=vendor -trimpath -ldflags "-w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-246-g76e9d81" -X github.com/openshift/sdn/pkg/version.commitFromGit="76e9d8125" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:02:24Z" " github.com/openshift/sdn/cmd/network-controller
go build -mod=vendor -trimpath -ldflags "-w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-246-g76e9d81" -X github.com/openshift/sdn/pkg/version.commitFromGit="76e9d8125" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:02:24Z" " github.com/openshift/sdn/cmd/openshift-sdn
go build -mod=vendor -trimpath -ldflags "-w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-246-g76e9d81" -X github.com/openshift/sdn/pkg/version.commitFromGit="76e9d8125" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:02:24Z" " github.com/openshift/sdn/cmd/sdn-cni-plugin
go build -mod=vendor -trimpath -ldflags "-w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-246-g76e9d81" -X github.com/openshift/sdn/pkg/version.commitFromGit="76e9d8125" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:02:24Z" " github.com/containernetworking/plugins/plugins/ipam/host-local
go build -mod=vendor -trimpath -ldflags "-w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-246-g76e9d81" -X github.com/openshift/sdn/pkg/version.commitFromGit="76e9d8125" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:02:24Z" " k8s.io/kubernetes/cmd/kube-proxy
[jdesousa@systemv /home/jdesousa/go/src/github.com/openshift/sdn] (build-not-stripped)
$ file openshift-sdn 
openshift-sdn: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=03d1ef18e5dd6676db6b108a00658e877bf19fb3, for GNU/Linux 3.2.0, not stripped
[jdesousa@systemv /home/jdesousa/go/src/github.com/openshift/sdn] (build-not-stripped)
$ git checkout -
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

[jdesousa@systemv /home/jdesousa/go/src/github.com/openshift/sdn] (master)
$ make
go build -mod=vendor -trimpath -ldflags "-s -w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-245-gf665e21" -X github.com/openshift/sdn/pkg/version.commitFromGit="f665e2195" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:03:10Z" " github.com/openshift/sdn/cmd/network-controller
go build -mod=vendor -trimpath -ldflags "-s -w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-245-gf665e21" -X github.com/openshift/sdn/pkg/version.commitFromGit="f665e2195" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:03:10Z" " github.com/openshift/sdn/cmd/openshift-sdn
go build -mod=vendor -trimpath -ldflags "-s -w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-245-gf665e21" -X github.com/openshift/sdn/pkg/version.commitFromGit="f665e2195" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:03:10Z" " github.com/openshift/sdn/cmd/sdn-cni-plugin
go build -mod=vendor -trimpath -ldflags "-s -w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-245-gf665e21" -X github.com/openshift/sdn/pkg/version.commitFromGit="f665e2195" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:03:10Z" " github.com/containernetworking/plugins/plugins/ipam/host-local
go build -mod=vendor -trimpath -ldflags "-s -w -X github.com/openshift/sdn/pkg/version.versionFromGit="v0.0.0-alpha.0-245-gf665e21" -X github.com/openshift/sdn/pkg/version.commitFromGit="f665e2195" -X github.com/openshift/sdn/pkg/version.gitTreeState="clean" -X github.com/openshift/sdn/pkg/version.buildDate="2020-11-13T16:03:10Z" " k8s.io/kubernetes/cmd/kube-proxy
[jdesousa@systemv /home/jdesousa/go/src/github.com/openshift/sdn] (master)
$ file openshift-sdn 
openshift-sdn: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=49de3e090bfc7c8e6ccc90e8dfbbeb97221e5525, for GNU/Linux 3.2.0, stripped

juanluisvaladas · 2020-11-13T21:10:14Z

/retest

squeed · 2020-11-16T14:33:49Z

Do we just want to do this for all go binaries? Should we get this up in library-go?

juanluisvaladas · 2020-11-18T02:01:50Z

I don't think that's something everyone wants to do, the build-machinery-go sets the -s explicitly and, I assume, deliberately:
https://github.com/openshift/build-machinery-go/blob/cd7e6e844b551f45007dd5a3200c140f6b5f6215/make/lib/golang.mk#L63

squeed · 2020-11-18T11:29:27Z

huh, fair enough.

squeed · 2020-11-18T11:29:54Z

/approve
/lgtm

openshift-ci-robot · 2020-11-18T11:30:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanluisvaladas, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [squeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-18T14:09:14Z

/retest