[release-4.6] Bug 1904455: NetworkPolicy performance (pod caching) #228

openshift-cherrypick-robot · 2020-12-04T14:04:53Z

This is an automated cherry-pick of #226

/assign danwinship

Rather than invoking the informer handlers directly, use a fake client and actually create/delete objects and let the informers be invoked normally. (In preparation for making use of the informer caches from the handlers.) Additionally, use a dummied-out BoundedFrequencyRunner to verify that syncs occur as expected.

Especially, we were previously copying all of the pods rather than just keeping pointers to the objects in the cache (probably a leftover from very old pre-shared-informer code). This may also fix leaks when pods are deleted and recreated, since informers apparently compress events based on namespace+name, not UID, so a delete+recreate would be compressed to an update, and we'd never get a delete for the old UID.

When syncing multiple namespaces, do them all in a single OVS transaction rather than a transaction per namespace

…cking In large clusters, recalculating networkpolicies after pod/namespace changes may take a lot of effort. Additionally, in some cases we may end up unnecessarily recalculating multiple times before pushing changes to OVS. Fix this by moving the recalculating step into the BoundedFrequencyRunner's thread, doing it just before we push the updates to OVS.

openshift-ci-robot · 2020-12-04T14:05:06Z

@openshift-cherrypick-robot: Bugzilla bug 1896958 has been cloned as Bugzilla bug 1904455. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1904455: NetworkPolicy performance (pod caching)

In response to this:

[release-4.6] Bug 1896958: NetworkPolicy performance (pod caching)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-04T14:05:35Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1904455, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1896958 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1896958 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

[release-4.6] Bug 1904455: NetworkPolicy performance (pod caching)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danwinship · 2020-12-07T12:22:02Z

/lgtm
/retest

openshift-ci-robot · 2020-12-07T12:22:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-12-07T14:52:05Z

/retest