Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1915007: Revert NetworkPolicy performance fixes (4.6) #241

Merged
merged 1 commit into from Jan 11, 2021
Merged

Bug 1915007: Revert NetworkPolicy performance fixes (4.6) #241

merged 1 commit into from Jan 11, 2021

Conversation

danwinship
Copy link
Contributor

This reverts commits 2b936ba, cad2bb7, 549a799, until we resolve the regression (https://bugzilla.redhat.com/show_bug.cgi?id=1914284)

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 11, 2021
@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request references Bugzilla bug 1904455, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1896958 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1896958 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

Bug 1904455: Revert NetworkPolicy performance fixes (4.6)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@sdodson
Copy link
Member

sdodson commented Jan 11, 2021

/retitle Bug 1915007: Revert NetworkPolicy performance fixes (4.6)

@openshift-ci-robot openshift-ci-robot changed the title Bug 1904455: Revert NetworkPolicy performance fixes (4.6) Bug 1915007: Revert NetworkPolicy performance fixes (4.6) Jan 11, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 11, 2021
@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request references Bugzilla bug 1915007, which is invalid:

  • expected dependent Bugzilla bug 1914284 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1915007: Revert NetworkPolicy performance fixes (4.6)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 11, 2021
@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 11, 2021
@juanluisvaladas
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, juanluisvaladas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 11, 2021
@sdodson
Copy link
Member

sdodson commented Jan 11, 2021

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 7106dab into openshift:release-4.6 Jan 11, 2021
@openshift-ci-robot
Copy link
Contributor

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 1915007 has been moved to the MODIFIED state.

In response to this:

Bug 1915007: Revert NetworkPolicy performance fixes (4.6)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the revert-networkpolicy-perf-fixes-46 branch January 12, 2021 13:51
danwinship added a commit to danwinship/sdn that referenced this pull request Jan 21, 2021
@danwinship
Revert "Merge pull request openshift#241 from danwinship/revert-netwo…
3b1e799 
…rkpolicy-perf-fixes-46"

This reverts commit 7106dab, reversing
changes made to adcf1b2.
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 10, 2021
Merged
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/sdn that referenced this pull request Feb 10, 2021
@danwinship
Revert "Merge pull request openshift#241 from danwinship/revert-netwo…
52553f9 
…rkpolicy-perf-fixes-46"

This reverts commit 7106dab, reversing
changes made to adcf1b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed Awaiting requested review from squeed

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@juanluisvaladas juanluisvaladas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danwinship @openshift-ci-robot @sdodson @juanluisvaladas @openshift-merge-robot