Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1941993: Fix incorrect unmonitoring of egress nodes #279

Merged
merged 1 commit into from
Apr 10, 2021
Merged

[release-4.7] Bug 1941993: Fix incorrect unmonitoring of egress nodes #279

merged 1 commit into from
Apr 10, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #275

/assign alexanderConstantinescu

@alexanderConstantinescu
Fix incorrect unmonitoring of egress nodes
906a397 
Currently we incorrectly unmonitoring an egress node whenever
any egress IP stops referencing that node, this is incorrect
because there might be other egress IPs (defined on a separate
namespace) that stills references that egress node. Consider
the following example:

```
oc get hostsubnet
NAME                             HOST                             HOST IP          SUBNET          EGRESS CIDRS   EGRESS IPS
huirwang-45-xslwp-master-0       huirwang-45-xslwp-master-0       172.31.249.251   10.128.0.0/23
huirwang-45-xslwp-master-1       huirwang-45-xslwp-master-1       172.31.249.250   10.130.0.0/23
huirwang-45-xslwp-master-2       huirwang-45-xslwp-master-2       172.31.249.45    10.129.0.0/23                  [172.31.249.205 172.31.249.206]
huirwang-45-xslwp-worker-4hhvt   huirwang-45-xslwp-worker-4hhvt   172.31.249.182   10.131.0.0/23                  [172.31.249.203 172.31.249.204]
huirwang-45-xslwp-worker-mssqh   huirwang-45-xslwp-worker-mssqh   172.31.249.112   10.128.2.0/23

oc get netnamespace
...
test1                                                13617042   [172.31.249.203 172.31.249.205]
test2                                                14768742   [172.31.249.204 172.31.249.206]
```

If someone now decides to remove the egress IPs associated with
test2: it will lead to having both egress nodes huirwang-45-xslwp-worker-4hhvt
and huirwang-45-xslwp-master-2 unmonitored, this can be seen
in the SDN logs on the worker node hosting the workload pods
as:

```
I0310 13:00:47.380770    4220 egressip.go:411] Removing egress IP 172.31.249.206 from node 172.31.249.45
I0310 13:00:47.380828    4220 vxlan_monitor.go:110] Unmonitoring node 172.31.249.45
I0310 13:00:47.380834    4220 egressip.go:411] Removing egress IP 172.31.249.204 from node 172.31.249.182
I0310 13:00:47.380837    4220 vxlan_monitor.go:110] Unmonitoring node 172.31.249.182
```

This is however incorrect as the egress IPs in namespace test1
still has a reference to those egress nodes.

This patch fixes that.

Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1926931 has been cloned as Bugzilla bug 1941993. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1941993: Fix incorrect unmonitoring of egress nodes

In response to this:

[release-4.7] Bug 1926931: Fix incorrect unmonitoring of egress nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1926931: Fix incorrect unmonitoring of egress nodes [release-4.7] Bug 1941993: Fix incorrect unmonitoring of egress nodes Mar 23, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Mar 23, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1941993, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1926931 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1926931 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (huirwang@redhat.com), skipping review request.

In response to this:

[release-4.7] Bug 1941993: Fix incorrect unmonitoring of egress nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 23, 2021
@alexanderConstantinescu
Copy link
Contributor

/assign @danwinship

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@russellb russellb added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2310aee into openshift:release-4.7 Apr 10, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1941993 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1941993: Fix incorrect unmonitoring of egress nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexanderConstantinescu
Copy link
Contributor

/cherry-pick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 11, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

@alexanderConstantinescu: new pull request created: #298

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@danwinship danwinship

@alexanderConstantinescu alexanderConstantinescu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @alexanderConstantinescu @danwinship @openshift-bot @russellb @openshift-merge-robot