Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a race condition in networkpolicy_test.go #312

Merged
merged 1 commit into from Jun 18, 2021

Conversation

danwinship
Copy link
Contributor

noticed while trying to debug https://bugzilla.redhat.com/show_bug.cgi?id=1937325, but this is just a test case bug, not a core networkpolicy code bug

@alexanderConstantinescu
Copy link
Contributor

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@danwinship
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor Author

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-gcp

this only changes the unit tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade, ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-gcp

this only changes the unit tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 838e02d into openshift:master Jun 18, 2021
@danwinship danwinship deleted the np-test-race-fix branch June 18, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants