Bug 1971808: fix local-with-fallback #320
Conversation
|
@danwinship: An error was encountered searching for bug 19718018 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
code 101: Bug #19718018 does not exist.
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
do-not-merge/work-in-progress
danwinship
changed the title
|
@danwinship: This pull request references Bugzilla bug 1971808, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
|
/retest |
|
ok, this seems to work AFAICT:
|
danwinship
force-pushed
the
local-with-fallback-v2
branch
from
e441dd4
to
847b677
Compare
danwinship
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aure |
|
/test e2e-azure |
|
@danwinship: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danwinship: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Whatever. GCP failures are infrastructural, and I was testing on GCP when I wrote #320 (comment) so I know it would work if the cluster actually came up. |
|
@danwinship: All pull requests linked via external trackers have merged: Bugzilla bug 1971808 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The new
local-with-fallbackhack was interfering with cluster-internal traffic to local-with-fallback services (which already would have worked fine even when there were no local pods), breaking cluster-internal source IP preservation (and maybe other things).This reverts the previous hack and replaces it with a hack that preserves almost all of the current handling of
externalTrafficPolicy: Localservices, and only changes the bit at the end. In particular, this preserves the short-circuit of pod-to-loadbalancer-IP for Local services, which the previous hack did not./cc @Miciah @smarterclayton @sgreene570
rebases to openshift/kubernetes#813