Bug 1991551: update usage of Events for 1.22 rebase #332
Conversation
|
@danwinship: This pull request references Bugzilla bug 1991551, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@danwinship: This pull request references Bugzilla bug 1991551, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
danwinship
changed the title
|
@danwinship: This pull request references Bugzilla bug 1991551, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
lgtm
openshift-controller-manager is not currently compatible with eventsv1.Event, and will fail to unidle pods as a result.
|
/retest |
|
/retest-required |
|
/test e2e-aws-upgrade |
| @@ -180,7 +182,15 @@ func (sdn *openShiftSDN) runProxy(waitChan chan<- bool) { | |||
| } | |||
|
|
|||
| if enableUnidling { | |||
| signaler := unidler.NewEventSignaler(recorder) | |||
| // FIXME: openshift-controller-manager assumes the LastTimestamp field in | |||
There was a problem hiding this comment.
Is there some way to track the fix we need to make in openshift-controller-manager for this?
There was a problem hiding this comment.
|
/lgtm I just wan't to make sure we actually remember to go back and fix the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astoycos, danwinship, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danwinship: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1991551 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The new
k8s.io/client-go/tools/eventsversion ofEventf()sneakily added a new argument before the trailing message+args, so we're ending up with events withThis adds an "action" to each event. The documentation is not very useful, but this seems consistent with how it is used in some places in k/k...
Additionally, it turns out that openshift-controller-manager is not compatible with openshift-sdn using the new Event API for unidling, because it assumes the
LastTimestampfield of the event will be set, but this field is deprecated ineventsv1.Event, and not set by the convenience APIs. Thus, for now, revert back to using the legacy API for the unidling proxy.