Replace utilruntime.HandleError() with klog.Errorf() #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
A long long time ago when openshift-sdn was still in-process in
kubelet/kcm, someone told us we had to use utilruntime.HandleError to
handle errors because it was extensible/configurable/etc. But these
days we know neither openshift-snd-node nor openshift-sdn-controller
makes use of that extensibility/configurability/etc, and using
HandleError() is inconvenient because we usually have to do
"utilruntime.HandleError(fmt.Errorf("...: %v", err))" anyway. So just
stop doing that.
danwinship
force-pushed
the
no-handleerror
branch
from
a1fdff0
to
1c4e4d4
Compare
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long long time ago when openshift-sdn was still in-process in
kubelet/kcm, someone told us we had to use utilruntime.HandleError to
handle errors because it was extensible/configurable/etc. But these
days we know neither openshift-snd-node nor openshift-sdn-controller
makes use of that extensibility/configurability/etc, and using
HandleError() is inconvenient because we usually have to do
"utilruntime.HandleError(fmt.Errorf("...: %v", err))" anyway. So just
stop doing that.