sdn-cni-plugin built without openssl and cgo #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
knobunc
requested changes
Nov 1, 2019
There was a problem hiding this comment.
We are building the two pieces the same way... That's wrong.
Only sdn-cni-plugin should be built with CGO_ENABLED=0
So either we need to build the different targets separately, or do the whole build twice with different env set and just copy the right binary from the right build.
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
openshift-ci-robot
added
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle CGO conditional in Makefile itself and
not in Dockerfile.rhel
Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org
@dougbtv @squeed PTAL