Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable injection of service CA bundle for CRDs #100

Merged
merged 3 commits into from Jan 23, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Jan 23, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2020
@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

@stlaz @sttts I've split the CRD injection from the webhook injection because I don't think there's anything controversial about the CRD case.

@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

2 similar comments
@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Jan 23, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7bb44c1 into openshift:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants