Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable injection of service CA bundle for admission webhooks #79

Merged
merged 2 commits into from Jan 24, 2020
Merged

Enable injection of service CA bundle for admission webhooks #79

merged 2 commits into from Jan 24, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Nov 4, 2019 •
edited

This PR adds support for injection of service CA bundle for MutatingWebhookConfiguration and ValidatingWebhookConfiguration, and supersedes #51.

Fixes #63

Co-authored-by: Daniel Spangenberg daniel.spangenberg@redhat.com

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2019
@marun marun force-pushed the webhook-cabundle-injection branch 9 times, most recently from 4503f2f to 72818ed Compare November 5, 2019 01:23
@marun marun mentioned this pull request Nov 5, 2019
Closed
@marun marun force-pushed the webhook-cabundle-injection branch 3 times, most recently from 7c80bdc to 2af841b Compare November 5, 2019 03:55
@marun
Copy link
Contributor Author

marun commented Nov 5, 2019

/retest

@stlaz
Copy link
Member

stlaz commented Nov 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
@lisa lisa mentioned this pull request Nov 5, 2019
Merged
@stlaz
Copy link
Member

stlaz commented Nov 13, 2019

/hold
just to make sure everything this PR depends on merges first

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2019
@marun
Copy link
Contributor Author

marun commented Nov 13, 2019

/hold
just to make sure everything this PR depends on merges first

Note that I used WIP (which guarantees do-not-merge/work-in-progress) because this PR includes the commits of #78 which has yet to merge. I also indicated in the initial comment that the PR would not be ready for review until the previous PR had merged. A rebase and removal of WIP in the PR title would be a precondition for reviewing, let alone merge.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@marun
Copy link
Contributor Author

marun commented Nov 15, 2019

Rebased

@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

@sttts @stlaz Rebased and ready for review. Not mergeable (hence the hold) pending an enhancement to determine whether it is acceptable to take an all-or-nothing approach to injection for webhooks.

@marun marun changed the title Enable injection of service CA bundle for webhooks WIP Enable injection of service CA bundle for webhooks Jan 23, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020
@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

5 similar comments
@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

marun and others added 2 commits January 23, 2020 15:35
@marun @spangenberg
Enable ca bundle injection for webhook configurations
125b0ba 
Co-authored-by: Daniel Spangenberg <daniel.spangenberg@redhat.com>
@marun
Update bindata
96dc972
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2020
@marun marun changed the title WIP Enable injection of service CA bundle for webhooks Enable injection of service CA bundle for webhooks Jan 23, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020
@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

Rebased!

@marun marun changed the title Enable injection of service CA bundle for webhooks Enable injection of service CA bundle for admission webhooks Jan 23, 2020
@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

And ready for review!

@marun
Copy link
Contributor Author

marun commented Jan 24, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Jan 24, 2020

/lgtm

Blocked by enhancement openshift/enhancements#184.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, stlaz, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor

sttts commented Jan 24, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 89b6df1 into openshift:master Jan 24, 2020
@bison bison mentioned this pull request Jan 28, 2020
Merged
@marun marun mentioned this pull request Feb 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX requested changes

@deads2k deads2k Awaiting requested review from deads2k

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@stlaz stlaz

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] webhook-cabundle-injector controller
6 participants
@marun @stlaz @JAORMX @sttts @openshift-ci-robot @openshift-merge-robot