Refactor ca bundle injection for maintainability #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
marun
force-pushed
the
cabundle-injection
branch
8 times, most recently
from
4e0e351
to
6917d77
Compare
marun
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
marun
force-pushed
the
cabundle-injection
branch
7 times, most recently
from
888d623
to
7bbc35a
Compare
|
/retest e2e-aws failure should be fixed by the merge of openshift/origin#24085 |
|
/retest |
marun
force-pushed
the
cabundle-injection
branch
from
7bbc35a
to
2181e94
Compare
marun
force-pushed
the
cabundle-injection
branch
from
2181e94
to
7e6e48a
Compare
marun
force-pushed
the
cabundle-injection
branch
from
d352c1e
to
b41c48f
Compare
|
/retest |
marun
force-pushed
the
cabundle-injection
branch
5 times, most recently
from
bb60c64
to
57c83d7
Compare
|
/retest |
marun
force-pushed
the
cabundle-injection
branch
2 times, most recently
from
51e3ac2
to
32406ab
Compare
|
/retest |
marun
force-pushed
the
cabundle-injection
branch
from
32406ab
to
23167f2
Compare
marun
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Rebased and ready for review |
Previously injecting ca bundles into configmap and apiservices required running separate processes. With the need to add injection support for mutating and validating webhookconfigurations, it was time to factor out common code and allow a single process to run controllers for all supported injection targets.
marun
force-pushed
the
cabundle-injection
branch
from
23167f2
to
08961f3
Compare
|
Rebased to pick up the extended polling timeout |
|
Unrelated flakes. /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun, stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously injecting ca bundles into configmap and apiservices required running separate processes. With the need to add injection support for mutating and validating webhookconfigurations, it was time to factor out common code and allow a single process to run controllers for all supported injection targets.