Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.10] Enable passing a kubeconfig file to apiserver #12

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #11

/assign kargakis

MHBauer and others added 2 commits July 5, 2018 18:22
The servicecatalog apiserver may need to run outside the
cluster but still need a way to contact the core api server.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: kargakis.

Note that only openshift members and repo collaborators can be assigned.

In response to this:

This is an automated cherry-pick of #11

/assign kargakis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 5, 2018
@jpeeler
Copy link

jpeeler commented Jul 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpeeler, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2018
@openshift-merge-robot openshift-merge-robot merged commit 41bdbe8 into openshift:release-3.10 Jul 5, 2018
@jpeeler
Copy link

jpeeler commented Jul 5, 2018

I just noticed this is the wrong branch. For now, I'm just going to move these patches over to the correct branch. Perhaps in the future I can align the branch naming to openshift's.

@0xmichalis
Copy link

@jpeeler I don't see the 3.10 dockerhub image updated. Do you know whether branch-ci-openshift-service-catalog-images is publishing to dockerhub? If so, do we need to make it work for openshift-3.10?

@jpeeler
Copy link

jpeeler commented Jul 10, 2018

Yes, I'm pretty sure that's what handles the image pushes. I'll add the 3.10 branch (which has now shifted back to release-3.10).

@0xmichalis
Copy link

ping me on the release PR and I can get it merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants