-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.10] Enable passing a kubeconfig file to apiserver #12
[release-3.10] Enable passing a kubeconfig file to apiserver #12
Conversation
The servicecatalog apiserver may need to run outside the cluster but still need a way to contact the core api server.
@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: kargakis. Note that only openshift members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeeler, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I just noticed this is the wrong branch. For now, I'm just going to move these patches over to the correct branch. Perhaps in the future I can align the branch naming to openshift's. |
@jpeeler I don't see the 3.10 dockerhub image updated. Do you know whether branch-ci-openshift-service-catalog-images is publishing to dockerhub? If so, do we need to make it work for |
Yes, I'm pretty sure that's what handles the image pushes. I'll add the 3.10 branch (which has now shifted back to release-3.10). |
ping me on the release PR and I can get it merged |
This is an automated cherry-pick of #11
/assign kargakis