Skip to content
This repository has been archived by the owner on Mar 26, 2019. It is now read-only.

Filter operator informer events #54

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

mrogers950
Copy link
Contributor

Only queue up on the resources that we care about, rather than everything.
@openshift/sig-auth

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2018
@sjenning
Copy link

sjenning commented Nov 14, 2018

wrt apiserver request rates, seems to still be high

{client="openshift-service-cert-signer-operator service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format"} | 10.333333333333334
{client="service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format"} | 4

however, with the broken out clients, we can tell which is which now 👍

sort_desc(sum by (verb) (rate(apiserver_request_count{client="openshift-service-cert-signer-operator service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format"}[1m])))

{verb="GET"} | 8.666666666666666
{verb="PUT"} | 1
{verb="UPDATE"} | 0.6666666666666666
{verb="WATCH"} | 0.03333333333333333

sort_desc(sum by (resource, namespace) (rate(apiserver_request_count{client="openshift-service-cert-signer-operator service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format",verb="GET"}[1m])))

{namespace="default",resource="configmaps"} | 1.6666666666666667
{namespace="default",resource="namespaces"} | 1
{namespace="default",resource="clusterrolebindings"} | 1
{namespace="default",resource="clusterroles"} | 1
{namespace="default",resource="services"} | 1
{namespace="default",resource="deployments"} | 1
{namespace="default",resource="serviceaccounts"} | 1
{namespace="default",resource="secrets"} | 0.3333333333333333
{namespace="default",resource="servicecertsigneroperatorconfigs"} | 0.3333333333333333
{namespace="default",resource="clusteroperators"} | 0.3333333333333333

sort_desc(sum by (resource, namespace) (rate(apiserver_request_count{client="openshift-service-cert-signer-operator service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format",verb="PUT"}[1m])))

{namespace="default",resource="clusterrolebindings"} | 1.0000000000000002
sort_desc(sum by (verb) (rate(apiserver_request_count{client="service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format"}[1m])))

{verb="GET"} | 2
{verb="PUT"} | 2

sort_desc(sum by (resource, namespace) (rate(apiserver_request_count{client="service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format",verb="GET"}[1m])))

{namespace="default",resource="configmaps"} | 2

sort_desc(sum by (resource, namespace) (rate(apiserver_request_count{client="service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format",verb="PUT"}[1m])))

{namespace="default",resource="configmaps"} | 2

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2018
@mrogers950
Copy link
Contributor Author

@enj updated to use the new filter functions.

@enj
Copy link
Contributor

enj commented Nov 27, 2018

/lgtm

Good start. We will tackle the status update and informer configuration next. Hopefully after those bits are nailed down, this operator will be nice and quiet.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2018
@openshift-merge-robot openshift-merge-robot merged commit 726b188 into openshift:master Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants