-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated golang.org/x/text to v0.3.7 Fixes Bug 2105595 #685
Conversation
@vrindle: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @vrindle. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrindle The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vrindle: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vrindle: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
FYI: Upstream has this commit that bumps golang.org/x/text to v0.3.7. 38fb014#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
we already have that here also https://github.com/openshift/sriov-network-operator/blob/master/go.mod#L137 Am I missing something? |
We realize the fix is in master, but it's not in 4.11. https://bugzilla.redhat.com/show_bug.cgi?id=2105596#c4 |
Hi @vrindle don't worry I am going to do a backport of the 1.18 bump to 4.11 as OCP 4.11 also uses golang 1.18 that should fix the issue |
it will get fixed here #688 |
@vrindle: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close This was fixed by the backport |
@SchSeba: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…/go_modules/golang.org/x/net-0.23.0 Bump golang.org/x/net from 0.17.0 to 0.23.0
Fixes this bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2105595