Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated golang.org/x/text to v0.3.7 Fixes Bug 2105595 #685

Closed
wants to merge 1 commit into from

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Aug 16, 2022

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

@vrindle: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updated golang.org/x/text to v0.3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

Hi @vrindle. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrindle
Once this PR has been reviewed and has the lgtm label, please assign pliurh for approval by writing /assign @pliurh in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

@vrindle: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrindle vrindle changed the title Updated golang.org/x/text to v0.3.7 Updated golang.org/x/text to v0.3.7 Fixes Bug 2105595 Aug 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

@vrindle: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updated golang.org/x/text to v0.3.7 Fixes Bug 2105595

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wizhaoredhat
Copy link
Contributor

FYI: Upstream has this commit that bumps golang.org/x/text to v0.3.7. 38fb014#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
In your case, I think just changing the golang.org/x/text should be fine as just a downstream commit on a release branch. Although I would be interested what the rules for this is.

@SchSeba
Copy link
Contributor

SchSeba commented Aug 17, 2022

we already have that here also https://github.com/openshift/sriov-network-operator/blob/master/go.mod#L137

Am I missing something?

@vrindle
Copy link
Contributor Author

vrindle commented Aug 19, 2022

we already have that here also https://github.com/openshift/sriov-network-operator/blob/master/go.mod#L137

Am I missing something?

We realize the fix is in master, but it's not in 4.11. https://bugzilla.redhat.com/show_bug.cgi?id=2105596#c4

@SchSeba
Copy link
Contributor

SchSeba commented Aug 22, 2022

Hi @vrindle don't worry I am going to do a backport of the 1.18 bump to 4.11 as OCP 4.11 also uses golang 1.18 that should fix the issue

@SchSeba
Copy link
Contributor

SchSeba commented Aug 29, 2022

it will get fixed here #688

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2022
@openshift-merge-robot
Copy link
Contributor

@vrindle: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SchSeba
Copy link
Contributor

SchSeba commented Aug 30, 2022

/close

This was fixed by the backport

@openshift-ci openshift-ci bot closed this Aug 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2022

@SchSeba: Closed this PR.

In response to this:

/close

This was fixed by the backport

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SchSeba added a commit to SchSeba/sriov-network-operator that referenced this pull request May 5, 2024
…/go_modules/golang.org/x/net-0.23.0

Bump golang.org/x/net from 0.17.0 to 0.23.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants