Bug OCPBUGS-522: Backport support golang 1.18 #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orted card listing - Update docs with newly supported hardware - Update supported device ids in config map
Fixes issue openshift#249 Signed-off-by: Fred Rolland <frolland@nvidia.com>
Signed-off-by: Fred Rolland <frolland@nvidia.com>
This PR fix issues found with: golangci-lint run --disable-all -E unused Signed-off-by: Fred Rolland <frolland@nvidia.com>
This commit fix the issues found by: `golangci-lint run --disable-all -E whitespace` Signed-off-by: Fred Rolland <frolland@nvidia.com>
This commit fix the issues found by: `golangci-lint run --disable-all -E deadcode` and `golangci-lint run --disable-all -E goimports` Signed-off-by: Fred Rolland <frolland@nvidia.com>
This commit fixes issues found by `golangci-lint run --disable-all -E misspell` and `golangci-lint run --disable-all -E staticcheck` Signed-off-by: Fred Rolland <frolland@nvidia.com>
Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
If error occures during sriov configuration in generic plugin, config daemon will log the error and requeue the request to reconcile the node. On the next run, when generic plugin Apply() method is called, interface configuration may be skipped, leaving the interface partially configured. To ensure generic plugin re-configures the interface on the next iteration, we reset the interface before returning an error. This will also ensure that a drain will be requested as well. Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
In case of error, it is useful to know the reason why it was not possible to get the IP address of SR-IOV interface. Add description to each returned error and return an error in case the requested interface is not found. Add "github.com/stretchr/testify/assert" dependency adn unit tests for GetSriovNicIPs Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
This commit fixes issues found with: `golangci-lint run --disable-all -E gosimple` Signed-off-by: Fred Rolland <frolland@nvidia.com>
Fix issues found by: `golangci-lint run --disable-all -E ineffassign` Signed-off-by: Fred Rolland <frolland@nvidia.com>
This commit fixes issues found by `golangci-lint run --disable-all -E stylecheck` Signed-off-by: Fred Rolland <frolland@nvidia.com>
With Kubernetes 1.24, master nodes are now labeld and tainted as `node-role.kubernetes.io/control-plane` Support this in sriov network operator by: - extending tolerations in relevant yaml files - adjusting node affinity in relevant yaml files - modify helm chart to deploy operator based on node affinity and not node selector Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Fixed expected log for release the VFs test case
Signed-off-by: Fred Rolland <frolland@nvidia.com>
Signed-off-by: Fred Rolland <frolland@nvidia.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
We don't need to check for ifaceStatus.NumVfs in a 'needDrainNode' function because it blocks drain after node reboot. Closes: openshift#322 Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
This commit removes the go plugins for vendors. Fixes: k8snetworkplumbingwg/sriov-network-operator#90 Signed-off-by: Sebastian Sch <sebassch@gmail.com>
The Intel series of E810 cards with a 1591 PF ID is added to the supported card listing - Update docs with newly supported hardware - Update supported device ids in config map
Configure CI to collect coverage and integrate with coveralls.io service. Add Makefile rules for merging coverage profiles from multiple sources, as tests are usually run by `make test-pkg` and `make test-controllers`. Add Makefile's rules to download gocovmerge and gcov2lcov. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
When sending a Refresh message to Writer's refresh channel, if the state is "Succeeded" or "Failed", the Writer will update the sync channel when finished. Therefore there is a need to wait on sync channel on the Daemon side when sending "Succeeded" or "Failed". Signed-off-by: Fred Rolland <frolland@nvidia.com>
There is a stage when the SriovNetworkNodeState is initializing where the spec is empty because the SriovNetworkNodePolicyReconciler did not yet applied the policies. It can cause a non required action by the plugins, that will try to apply the empty spec by resetting the NIC for example. The config daemon will not run the plugins if the generation is 1 and the Spec.Interfaces is empty. Solves issue openshift#283 For e2e tests, the wait timeout to get to initial Sync state has been increased. This change is needed as now the config daemon will not apply on "empty" spec until the SriovNetworkNodePolicyReconciler will iterate on the Interfaces. The reconcile loop interval is 5 minutes, so the test timeout needed to be increased. Signed-off-by: Fred Rolland <frolland@nvidia.com>
This commit is needed when using DPDK with vhost-net in virtio mode. We must load the vhost-net kernel module if we don't want the dpdk application to run with privilege Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
backport_golang_4.11
branch
from
dc00f70
to
8503c7e
Compare
SchSeba
changed the title
|
@SchSeba: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/severity-critical
|
@zeeke: This pull request references [Jira Issue OCPBUGS-522](https://issues.redhat.com//browse/OCPBUGS-522), which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (elevin@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
bn222
reviewed
Aug 25, 2022
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
backport_golang_4.11
branch
from
8503c7e
to
6ada011
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222, SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@SchSeba: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
zshi-redhat
added
the
backport-risk-assessed
|
/cherry-pick-approved |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@SchSeba: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-522 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
SchSeba
added a commit
to SchSeba/sriov-network-operator
that referenced
this pull request
May 1, 2024
Support adding or removing node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.