Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet: whitelist alerts #119

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

squat
Copy link
Contributor

@squat squat commented Jan 25, 2019

This commit replaces the string ALERTS with alerts in the server's
whitelist to accept the metric that is automatically renamed on the
client.

The new content of the whitelist secret field is:

{__name__="up"}
{__name__="cluster_version"}
{__name__="cluster_operator_up"}
{__name__="cluster_operator_conditions"}
{__name__="cluster_version_payload"}
{__name__="cluster_version_payload_errors"}
{__name__="machine_cpu_cores"}
{__name__="machine_memory_bytes"}
{__name__="etcd_object_counts"}
{__name__="alerts",alertstate="firing"}

cc @brancz @smarterclayton

This commit replaces the string `ALERTS` with `alerts` in the server's
whitelist to accept the metric that is automatically renamed on the
client.

The new content of the whitelist secret field is:

{__name__="up"}
{__name__="cluster_version"}
{__name__="cluster_operator_up"}
{__name__="cluster_operator_conditions"}
{__name__="cluster_version_payload"}
{__name__="cluster_version_payload_errors"}
{__name__="machine_cpu_cores"}
{__name__="machine_memory_bytes"}
{__name__="etcd_object_counts"}
{__name__="alerts",alertstate="firing"}
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 25, 2019
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [smarterclayton,squat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e02b7b1 into openshift:master Jan 25, 2019
@squat squat deleted the whitelistalerts branch January 25, 2019 20:58
@openshift-ci-robot
Copy link
Contributor

@squat: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws ee4a19a link /test e2e-aws
ci/prow/images ee4a19a link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants