Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storage to prometheus #126

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Add storage to prometheus #126

merged 1 commit into from
Feb 15, 2019

Conversation

jfchevrette
Copy link
Member

This adds 500Gi PVCs to prometheus replicas.

Commit contains both the jsonnet changes and the resulting manifest changes

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2019
@jfchevrette jfchevrette mentioned this pull request Feb 15, 2019
Closed
squat
squat approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jfchevrette, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@openshift-merge-robot openshift-merge-robot merged commit abd9473 into openshift:master Feb 15, 2019
@jfchevrette jfchevrette deleted the add_storage branch February 15, 2019 15:31
@squat squat mentioned this pull request Feb 15, 2019
Merged
@jfchevrette jfchevrette mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@brancz brancz Awaiting requested review from brancz

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@squat squat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jfchevrette @openshift-ci-robot @squat @openshift-merge-robot