pkg/cluster: fix running telemeter without verbose #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if telemeter-server is run without the `-v` flag, it will bail with the following error: ``` level=info caller=main.go:156 ts=2019-12-11T14:09:52.043501508Z msg="Telemeter server initialized." level=error caller=main.go:159 ts=2019-12-11T14:09:52.221533957Z err="unable to configure cluster: Cannot specify both LogOutput and Logger. Please choose a single log configuration setting." ``` This commit fixes the configuration of the logger for memberlist so that it telemeter-server can be run without `-v`. XREF: openshift#237 Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
openshift-ci-robot
added
approved
|
/lgtm |
bwplotka
approved these changes
Dec 11, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, bwplotka, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if telemeter-server is run without the
-vflag, it willbail with the following error:
This commit fixes the configuration of the logger for memberlist so that
it telemeter-server can be run without
-v.XREF: #237
cc @kakkoyun @metalmatze @brancz @bwplotka
Signed-off-by: Lucas Servén Marín lserven@gmail.com