pkg/cache: update memcached dns on interval #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
squat
force-pushed
the
refreshmemcacheddns
branch
from
b9c38fd
to
5172da1
Compare
openshift-ci-robot
added
the
approved
brancz
reviewed
Dec 12, 2019
pkg/cache/memcached/memcached.go
Outdated
| expiration int32 | ||
| sync.RWMutex |
There was a problem hiding this comment.
I'm not a huge fan of exposing these, I've seen this cause problems in the past as the methods happen to be callable from the outside.
|
Just a small comment, otherwise lgtm |
We need to be able to update the DNS for the Memcached DNS servers to keep up with changes in the IPs of the servers. This implements a simple time-based DNS update. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
squat
force-pushed
the
refreshmemcacheddns
branch
from
5172da1
to
3286928
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to update the DNS for the Memcached DNS servers
to keep up with changes in the IPs of the servers. This implements a
simple time-based DNS update.
Signed-off-by: Lucas Servén Marín lserven@gmail.com
cc @metalmatze @brancz @kakkoyun