Add missing jsonnet binary to builds #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
|
/retest |
squat
reviewed
Jan 23, 2020
kakkoyun
force-pushed
the
fix_jsonnet_bin
branch
from
00bf41d
to
83ec637
Compare
|
friendly ping @squat |
squat
suggested changes
Jan 24, 2020
Makefile
Outdated
| @@ -201,6 +202,9 @@ $(PROMETHEUS_BIN): $(BIN_DIR) | |||
| $(EMBEDMD_BIN): $(BIN_DIR) | |||
| GO111MODULE=on go build -mod=vendor -o $@ github.com/campoy/embedmd | |||
|
|
|||
| $(JSONNET): $(BIN_DIR) | |||
There was a problem hiding this comment.
This should be $(JSONNET_BIN) right?
There was a problem hiding this comment.
Yes, thanks for catching that.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kakkoyun, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ack, this works, and the var rename made the makefile clearer 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Jsonnet issues in makefile.
cc @squat @cben