Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move benchmark to remote write #313

Merged
merged 3 commits into from Mar 3, 2020
Merged

Move benchmark to remote write #313

merged 3 commits into from Mar 3, 2020

Conversation

squat
Copy link
Contributor

@squat squat commented Feb 27, 2020

This PR migrates the Telemeter server benchmark tests from the
Prometheus to the remote-write architecture. This will allow us to
completely eliminate the Prometheus storage stack, including manifests
and go code.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2020
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 27, 2020
@squat squat force-pushed the move-benchmark-to-remote-write branch from cea5365 to c7e1a3c Compare February 27, 2020 16:21
@squat
jsonnet: move benchmark to remote-write
9104510 
This commit migrates the Telemeter server benchmark tests from the
Prometheus to the remote-write architecture. This will allow us to
completely eliminate the Prometheus storage stack, including manifests
and go code.

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@squat
manifests: regenerate
e8ef1d6 
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@squat squat force-pushed the move-benchmark-to-remote-write branch from c7e1a3c to e8ef1d6 Compare February 27, 2020 16:22
@squat squat marked this pull request as ready for review February 27, 2020 16:22
@squat
Copy link
Contributor Author

squat commented Feb 27, 2020

/ok-to-test

@squat
Copy link
Contributor Author

squat commented Feb 27, 2020

/refresh

@openshift-ci-robot openshift-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 27, 2020
@squat
Copy link
Contributor Author

squat commented Feb 27, 2020

unblocks: #271

@brancz brancz removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2020
@squat
Copy link
Contributor Author

squat commented Feb 27, 2020

/test e2e-aws

@squat
Copy link
Contributor Author

squat commented Feb 27, 2020

This is failing because the benchmark test is not using the telemeter image built from the code in the PR. It is using quay.io/openshift/origin-telemeter:v4.0, which does not support the --forward-url flag.

We need to update the tests to use the telemeter image built from the source.

@squat
Copy link
Contributor Author

squat commented Mar 2, 2020

/test e2e-aws

@squat
Copy link
Contributor Author

squat commented Mar 2, 2020

/test benchmark

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020
@squat
Copy link
Contributor Author

squat commented Mar 2, 2020

/retest

@squat squat force-pushed the move-benchmark-to-remote-write branch from f02c8fa to 3510575 Compare March 3, 2020 09:54
@squat
Makefile: allow CI to override benchmark image
fbb6378 
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@squat squat force-pushed the move-benchmark-to-remote-write branch from 3510575 to fbb6378 Compare March 3, 2020 11:11
@squat
Copy link
Contributor Author

squat commented Mar 3, 2020

/retest

@brancz
Copy link
Contributor

brancz commented Mar 3, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2020
@brancz
Copy link
Contributor

brancz commented Mar 3, 2020

As a follow up, let's remove the prometheus operator dependency in the jsonnetfile, as this is not required anymore, coincidentally that will make bumping kube-prometheus a lot easier in cluster-monitoring-operator! 🎉

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bbd1fda into openshift:master Mar 3, 2020
@squat squat deleted the move-benchmark-to-remote-write branch March 3, 2020 13:28
@squat squat mentioned this pull request Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom Awaiting requested review from paulfantom

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@squat @brancz @openshift-ci-robot @openshift-merge-robot