telemeter-server: Always set OpenShift telemetry tenant ID #332
Conversation
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, kakkoyun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -79,7 +77,7 @@ func (h *Handler) Receive(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
| req = req.WithContext(ctx) | |||
| req.Header.Add("THANOS-TENANT", r.Context().Value(authorize.TenantKey).(string)) | |||
There was a problem hiding this comment.
maybe we should make this configurable via a flag so we don't have to make a new PR to telemeter every time the tenant ID changes. WDYT?
There was a problem hiding this comment.
why would it change? it's kind of final ..
There was a problem hiding this comment.
when we run in different environments, or someone else runs this somewhere
There was a problem hiding this comment.
Hopefully, this is replaced by OIDC soo anyway, no? If so, we could just leave it as is and then update to the proper new flow later.
|
Merging this as we need it for our production system. This has nothing to do with anything shipped in OpenShift, it's entirely server side. |
@metalmatze @squat @kakkoyun @bwplotka @krasi-georgiev