add service account with correct roles to telemeter-client #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
squat
force-pushed
the
serviceaccount
branch
from
f25ab2d
to
3d0bf20
Compare
|
For consistency I think it would make sense to rather bind to the cluster-monitoring-view Role, because if we change that one the telemeter ClusterRole now would have to be adapted as well. |
|
@brancz great idea. I'll test this and make a new pr |
marcolan018
referenced
this pull request
in stolostron/metrics-collector
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to authenticate against a Prometheus k8s pod created by the Cluster Monitoring Operator, the bearer token must belong to a ServiceAccount with the following SAR
{"resource":"namespaces","verb":"get"}[0][0] https://github.com/openshift/cluster-monitoring-operator/blob/master/jsonnet/prometheus.jsonnet#L290
cc @s-urbaniak