New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsonnet/telemeter: Record which cloudpak a cluster appears to be #361
jsonnet/telemeter: Record which cloudpak a cluster appears to be #361
Conversation
All known cloudpaks install at least one of the 'ibm-common-service' operator or the 'ibm-licensing-operator'. To better track the known cloudpaks report a metric that encodes the cloudpak_type of a cluster. For now the only value reported is `unknown` to leave room to detect type in the future. A subsequent change will add this to the summary recording rule.
/retest |
1 similar comment
/retest |
@squat this is just the new recording rule (tested directly), does not integrate it into the overall rule so we can verify it's working |
ack, so that we don't prematurely break before verifying. /lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bwplotka, smarterclayton, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This is still manual redeploy, right? |
ack yes it is. I'll trigger a redeploy today 🚀 |
This commit bumps the Telemeter version installed by jb to include a new recording rule introduced in: openshift/telemeter#361. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
All known cloudpaks install at least one of the 'ibm-common-service'
operator or the 'ibm-licensing-operator'. To better track the known
cloudpaks report a metric that encodes the cloudpak_type of a cluster.
For now the only value reported is
unknown
to leave room to detecttype in the future.
A subsequent change will add this to the summary recording rule.