jsonnet/telemeter: Add a rule for normalizing ebs_account data #363
Conversation
openshift-ci-robot
added
the
approved
Combine the class and email_domain fields on subscription labels into a smaller subset query. Add internal as it is used today for legacy behavior, but leverage class to better discriminate between different types of accounts (Internal, Customer, Partner, or Evaluation). The resulting account_type should be used for classification of the customer type.
smarterclayton
force-pushed
the
ebs_class
branch
from
4971daa
to
4dc0d83
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Has this made it to stage or prod yet? |
|
no, not yet; builds are failing due to the extra comma on this line: https://github.com/openshift/telemeter/pull/363/files#diff-be5c1148fb8fb67639520db2cee9afe1d431aad3afeeb44ed20b1ab85660a0e5R69 submitting a patch now |
Combine the class and email_domain fields on subscription labels into
a smaller subset query. Add internal as it is used today for legacy
behavior, but leverage class to better discriminate between different
types of accounts (Internal, Customer, Partner, or Evaluation). The
resulting account_type should be used for classification of the
customer type.
Will be used for other joins and significantly reduces cardinality
of queries by avoiding subscription_labels