New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: enable jsonnetfmt check #365

Merged

openshift-merge-robot merged 2 commits into openshift:master from squat:jsonnetfmt

Dec 11, 2020

Contributor

squat commented Dec 10, 2020 •

edited

This commit adds a Makefile target to format all jsonnet code. It also
removes "shellcheck" from the "format" target, as it is a linting tool,
not a formatter.

Includes fix from #364

Signed-off-by: Lucas Servén Marín lserven@gmail.com


          jsonnet: fix typo

65a8436

This commit fixes a typo in the rule.libsonnet file that is breaking
builds.

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>

openshift-ci-robot requested review from bwplotka and smarterclayton

December 10, 2020 12:39

openshift-ci-robot added the approved label

squat mentioned this pull request

ci-operator: add telemeter format test openshift/release#14245

Merged

Contributor

kakkoyun commented Dec 10, 2020

/lgtm

openshift-ci-robot added the lgtm label

bwplotka approved these changes

View reviewed changes

Contributor

bwplotka left a comment

/lgtm

openshift-ci-robot assigned bwplotka

Contributor

bwplotka commented Dec 10, 2020

Thanks for this 💪🏽

Contributor

kakkoyun commented Dec 10, 2020

/test format

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

18 similar comments

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

squat force-pushed the jsonnetfmt branch from 7243859 to 0def952 Compare

December 11, 2020 12:04

openshift-ci-robot removed the lgtm label


          Makefile: enable jsonnetfmt check

00b069a

This commit adds a Makefile target to format all jsonnet code. It also
removes "shellcheck" from the "format" target, as it is a linting tool,
not a formatter.

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>

squat force-pushed the jsonnetfmt branch from 0def952 to 00b069a Compare

December 11, 2020 12:08

squat mentioned this pull request

jsonnet: fix typo #364

Closed

Contributor

smarterclayton commented Dec 11, 2020

/retest

Contributor

smarterclayton commented Dec 11, 2020

/lgtm

openshift-ci-robot assigned smarterclayton

openshift-ci-robot added the lgtm label

Contributor

openshift-ci-robot commented Dec 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bwplotka, kakkoyun, smarterclayton, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bwplotka,kakkoyun,smarterclayton,squat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

smarterclayton added the bugzilla/valid-bug label

openshift-merge-robot merged commit e8aa9e9 into openshift:master

squat deleted the jsonnetfmt branch

December 14, 2020 11:28

Contributor

smarterclayton commented Dec 18, 2020

Have we promoted the rule that blocked this to stage or prod yet? It looks like not, but wasn't sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment