New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-24983: Force kill jobs after integration v2 test finish #514
OCPBUGS-24983: Force kill jobs after integration v2 test finish #514
Conversation
Memcached remains stuck with graceful kill, this unblock the script and the ci lane Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh: This pull request references Jira Issue OCPBUGS-24983, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -7,7 +7,7 @@ | |||
set -euo pipefail | |||
|
|||
result=1 | |||
trap 'kill $(jobs -p); exit $result' EXIT | |||
trap 'kill -9 $(jobs -p); exit $result' EXIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment about the usage of the sigkill. In any case I'm wondering whether having just something along the lines of pkill -SIGKILL memcached would've worked but this serves to unblock the pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkill -SIGKILL memcached does not work, not sure why.
Add comment in new commit.
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, marioferh, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@marioferh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@marioferh: Jira Issue OCPBUGS-24983: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-24983 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build telemeter-container-v4.16.0-202402151410.p0.g9df5dd9.assembly.stream.el9 for distgit telemeter. |
/cherry-pick release-4.15 |
@marioferh: new pull request created: #515 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806 |
Memcached remains stuck with graceful kill
After #497 integration test lane is broken and time out is reached.
Force kill memcached after the execution of test let the lane finish correctly.