Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-24983: Force kill jobs after integration v2 test finish #514

Merged
merged 2 commits into from Feb 15, 2024
Merged

OCPBUGS-24983: Force kill jobs after integration v2 test finish #514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
defda70
Force kill jobs after integration v2 test finish
marioferh Feb 15, 2024
62e709c
add comment to explain force kill
marioferh Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/integration-v2.sh
View file
Open in desktop
Expand Up @@ -7,7 +7,8 @@
set -euo pipefail

result=1
trap 'kill $(jobs -p); exit $result' EXIT
# Force kill in order to unblock ci lane when memcached get stuck and never finished
trap 'kill -9 $(jobs -p); exit $result' EXIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about the usage of the sigkill. In any case I'm wondering whether having just something along the lines of pkill -SIGKILL memcached would've worked but this serves to unblock the pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkill -SIGKILL memcached does not work, not sure why.
Add comment in new commit.


(./authorization-server localhost:9101 ./test/tokens.json) &

Expand Down