-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1961158: Changing resolver to address thanos-ruler pod issues #57
Bug 1961158: Changing resolver to address thanos-ruler pod issues #57
Conversation
@prashbnair: This pull request references Bugzilla bug 1961158, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @prashbnair. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@prashbnair: This pull request references Bugzilla bug 1961158, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than modifying the downstream fork's default value, why can't we just change the value of the flag?
/bugzilla refresh |
@prashbnair: This pull request references Bugzilla bug 1961158, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@simonpasquier Can you please let @kakkoyun know why it was done this way in 4.7 |
Because the prometheus operator doesn't allow you to set the flag in a simple fashion: the resolver flag being hidden, we can't reasonably expose it in the Thanos ruler CRD and merge patch doesn't work because the container's In the short term, patching the downstream fork is unfortunately our only viable option since this issue blocks our ability to merge anything on the /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prashbnair, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/bugzilla cc-qa |
@juzhao: This pull request references Bugzilla bug 1961158, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tested with the not merged PR, issue is fixed |
@prashbnair: All pull requests linked via external trackers have merged: Bugzilla bug 1961158 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Verification