Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-1870 Gather list of volumes to pvb backup after execute actions #264

Closed
wants to merge 12 commits into from
Closed

OADP-1870 Gather list of volumes to pvb backup after execute actions #264

wants to merge 12 commits into from
+499 −99

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented May 8, 2023 •
edited

Gather list of volumes to pvb backup after execute actions so plugin can affect which volumes are in the backup

This PR for OADP-1870 unblocks OADP-1075

cherrypicks vmware-tanzu#6243

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

dymurray and others added 11 commits April 24, 2023 15:58
@dymurray @sseago
Dockerfile.ubi/travis local files
c1509a8 
add UBI dockerfiles
Use numeric user for velero-restic-restore-helper
Enable multiarch builds (vmware-tanzu#135)
Use arm64-graviton2 for arm builds (vmware-tanzu#137)
Add required keys for arm builds (vmware-tanzu#139)
Update Travis build job to work w/o changes on new branches
Use a full VM for arm
Use numeric non-root user for nonroot SCC compatibility
@rayfordj @sseago
Add BZ + Publish automation to repo (#82)
18be9fc 
(cherry picked from commit ccb545f)

Update PR-BZ automation mapping (#84)

(cherry picked from commit aa2b019)

Update PR-BZ automation (vmware-tanzu#92)

Co-authored-by: Rayford Johnson <rjohnson@redhat.com>
(cherry picked from commit ecc563f)

Add publish workflow (vmware-tanzu#108)

(cherry picked from commit f87b779)
@sseago
remove dependabot config from fork
37d860b
@sseago
use konveyor-0.15.0 for restic until konveyor-dev can be updated
2f1112c
@shubham-pampattiwar @sseago
add vsb to restore priority
6944e06
@kaovilai @sseago
Create Makefile.prow
6b15376
@kaovilai @sseago
Code-gen no longer required on verify
86feb24 
due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai @sseago
oadp-1.2: Update Makefile.prow to velero-restore-helper
bf611b6
@shubham-pampattiwar @sseago
Move VS deletion to backup-finalizer-controller (vmware-tanzu#255)
97e79f9 
pass missing params during controller registration

refactor code to avoid code duplication and fix tests

remove unused function

fix via make update
@sseago
velero 1.11 version update
0b84c4a 
merge with other Dockerfile.ubi commits after upstream release branch
@openshift-cherrypick-robot @eemcmullan @sseago
remove dataSource field in case of prior csi restore (vmware-tanzu#260)
9fbebed 
Co-authored-by: Emily McMullan <emcmulla@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Gather list of volumes to pvb backup after execute actions
33a12fa 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai force-pushed the volToBackupAfterExecuteActions branch from b8afc39 to 33a12fa Compare May 8, 2023 17:17
@kaovilai kaovilai changed the title volToBackupAfterExecuteActions OADP-1870 Gather list of volumes to pvb backup after execute actions May 8, 2023
@kaovilai kaovilai marked this pull request as ready for review May 8, 2023 17:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai marked this pull request as draft May 16, 2023 15:29
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 9, 2023
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jan 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 9, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kaovilai @openshift-bot @openshift-merge-robot @dymurray @rayfordj @sseago @shubham-pampattiwar @openshift-cherrypick-robot