Bug 1919336: Check if datastore belongs to a datastore cluster #28

gnufied · 2021-02-05T20:42:05Z

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1919336

Output after the change:

I0208 17:00:29.199915  150092 operator.go:251] CheckDefaultDatastore failed: defaultDatastore "team-ssd-intel" in vSphere configuration: datastore team-ssd-intel is part of intel-ds-cluster datastore cluster

openshift-ci-robot · 2021-02-05T20:42:08Z

@gnufied: This pull request references Bugzilla bug 1919336, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

WIP: Bug 1919336: Check if datastore belongs to a datastore cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-05T20:42:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gnufied · 2021-02-08T16:58:04Z

/bugzilla refresh

openshift-ci-robot · 2021-02-08T16:58:10Z

@gnufied: This pull request references Bugzilla bug 1919336, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-08T17:02:54Z

@gnufied: This pull request references Bugzilla bug 1919336, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1919336: Check if datastore belongs to a datastore cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gnufied · 2021-02-08T17:10:42Z

/bugzilla refresh

openshift-ci-robot · 2021-02-08T17:10:47Z

@gnufied: This pull request references Bugzilla bug 1919336, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/check/datastore.go

jsafrane · 2021-02-09T14:04:40Z

pkg/check/datastore.go

+			}
+		}
+	}
+	klog.V(2).Infof("Checked datastore %s for SRDS - no problems found", dataStoreName)


This is called for every StorageClass and might be too noisy.

increased the log level.

You increased it at wrong place, see above

yikes. fixed.

pkg/check/datastore.go

jsafrane · 2021-02-09T14:16:22Z

pkg/check/datastore.go

 	return nil
 }

+func checkForDatastoreCluster(ctx *CheckContext, dataStoreName string) error {


Perhaps for a subsequent PR: This is called for every StorageClass and loads non-trivial amount of data from vSphere. Would it be possible to call it only once per dataStorageName? I.e. with a cache somewhere in CheckStorageClasses? It's not that easy, because there is CheckDefaultDatastore too...

Yes we could. I think it might be worth caching the information within the same run. but once all the checks are run -we can automatically expire the cache, so as they aren't reused in next run.

Ensure that datastore check gets called Add unit tests for the same

fix test data to have datastore cluster

Also add comments that explains when alerts gets ignored

pkg/check/datastore.go

jsafrane · 2021-02-10T10:03:15Z

pkg/check/datastore.go

+			}
+		}
+	}
+	klog.V(2).Infof("Checked datastore %s for SRDS - no problems found", dataStoreName)


You increased it at wrong place, see above

pkg/check/datastore.go

also fix logging

gnufied · 2021-02-10T16:16:23Z

@jsafrane fixed the comments. PTAL

jsafrane · 2021-02-10T18:16:02Z

/lgtm

openshift-ci-robot · 2021-02-10T18:16:42Z

@gnufied: All pull requests linked via external trackers have merged:

openshift/vsphere-problem-detector#28

Bugzilla bug 1919336 has been moved to the MODIFIED state.

In response to this:

Bug 1919336: Check if datastore belongs to a datastore cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Feb 5, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 5, 2021

openshift-ci-robot requested review from jsafrane and tsmetana February 5, 2021 20:42

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021

gnufied changed the title ~~WIP: Bug 1919336: Check if datastore belongs to a datastore cluster~~ Bug 1919336: Check if datastore belongs to a datastore cluster Feb 8, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 8, 2021

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 8, 2021

gnufied force-pushed the add-datastore-cluster-check branch 2 times, most recently from 84f7a2c to ad4d8a3 Compare February 8, 2021 17:10

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 8, 2021

jsafrane reviewed Feb 9, 2021

View reviewed changes

gnufied added 2 commits February 9, 2021 23:22

Add checks for datastore

3c34324

Ensure that datastore check gets called Add unit tests for the same

Add test data for cluster

9cfad82

fix test data to have datastore cluster

gnufied force-pushed the add-datastore-cluster-check branch 2 times, most recently from e9ed0d3 to 07c8536 Compare February 10, 2021 04:34

refactor code to reuse getDatacenter function

687d0f1

Also add comments that explains when alerts gets ignored

gnufied force-pushed the add-datastore-cluster-check branch from 07c8536 to 687d0f1 Compare February 10, 2021 04:35

Change readme location and add some additional comments

1ffea30

jsafrane reviewed Feb 10, 2021

View reviewed changes

gnufied added 2 commits February 10, 2021 10:54

refactor code to reuse datacenter and datastore fetch functions

6c5ef4d

also fix logging

Return error when we can't find datastore

aed5b4e

openshift-ci-robot assigned jsafrane Feb 10, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021

openshift-merge-robot merged commit 23501bd into openshift:master Feb 10, 2021

gnufied mentioned this pull request Mar 2, 2021

Improve docs about vmotion openshift/openshift-docs#29499

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1919336: Check if datastore belongs to a datastore cluster #28

Bug 1919336: Check if datastore belongs to a datastore cluster #28

gnufied commented Feb 5, 2021 •

edited

openshift-ci-robot commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

gnufied commented Feb 8, 2021

openshift-ci-robot commented Feb 8, 2021

openshift-ci-robot commented Feb 8, 2021

gnufied commented Feb 8, 2021

openshift-ci-robot commented Feb 8, 2021

jsafrane Feb 9, 2021

gnufied Feb 10, 2021

jsafrane Feb 10, 2021

gnufied Feb 10, 2021

jsafrane Feb 9, 2021

gnufied Feb 10, 2021

jsafrane Feb 10, 2021

gnufied commented Feb 10, 2021

jsafrane commented Feb 10, 2021

openshift-ci-robot commented Feb 10, 2021

Bug 1919336: Check if datastore belongs to a datastore cluster #28

Bug 1919336: Check if datastore belongs to a datastore cluster #28

Conversation

gnufied commented Feb 5, 2021 • edited

openshift-ci-robot commented Feb 5, 2021

openshift-ci-robot commented Feb 5, 2021

gnufied commented Feb 8, 2021

openshift-ci-robot commented Feb 8, 2021

openshift-ci-robot commented Feb 8, 2021

gnufied commented Feb 8, 2021

openshift-ci-robot commented Feb 8, 2021

jsafrane Feb 9, 2021

Choose a reason for hiding this comment

gnufied Feb 10, 2021

Choose a reason for hiding this comment

jsafrane Feb 10, 2021

Choose a reason for hiding this comment

gnufied Feb 10, 2021

Choose a reason for hiding this comment

jsafrane Feb 9, 2021

Choose a reason for hiding this comment

gnufied Feb 10, 2021

Choose a reason for hiding this comment

jsafrane Feb 10, 2021

Choose a reason for hiding this comment

gnufied commented Feb 10, 2021

jsafrane commented Feb 10, 2021

openshift-ci-robot commented Feb 10, 2021

gnufied commented Feb 5, 2021 •

edited