Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1919336: Check if datastore belongs to a datastore cluster #28

Merged
merged 6 commits into from Feb 10, 2021
Merged

Bug 1919336: Check if datastore belongs to a datastore cluster #28

merged 6 commits into from Feb 10, 2021

Commits on Feb 10, 2021

  1. Add checks for datastore 

    Ensure that datastore check gets called
Add unit tests for the same
    @gnufied
    gnufied committed Feb 10, 2021
    Copy the full SHA
    3c34324 View commit details
    Browse the repository at this point in the history

  2. Add test data for cluster 

    fix test data to have datastore cluster
    @gnufied
    gnufied committed Feb 10, 2021
    Copy the full SHA
    9cfad82 View commit details
    Browse the repository at this point in the history

  3. refactor code to reuse getDatacenter function 

    Also add comments that explains when alerts gets ignored
    @gnufied
    gnufied committed Feb 10, 2021
    Copy the full SHA
    687d0f1 View commit details
    Browse the repository at this point in the history

  4. Change readme location and add some additional comments

    @gnufied
    gnufied committed Feb 10, 2021
    Copy the full SHA
    1ffea30 View commit details
    Browse the repository at this point in the history

  5. refactor code to reuse datacenter and datastore fetch functions 

    also fix logging
    @gnufied
    gnufied committed Feb 10, 2021
    Copy the full SHA
    6c5ef4d View commit details
    Browse the repository at this point in the history

  6. Return error when we can't find datastore

    @gnufied
    gnufied committed Feb 10, 2021
    Copy the full SHA
    aed5b4e View commit details
    Browse the repository at this point in the history