Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1990113: Syncs with upstream for leader election [backport 4.8] #63

Merged
merged 86 commits into from Sep 10, 2021
Merged

Bug 1990113: Syncs with upstream for leader election [backport 4.8] #63

merged 86 commits into from Sep 10, 2021

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Aug 24, 2021

No description provided.

ohamada and others added 30 commits July 16, 2020 18:10
@ohamada
whereabouts.kubeconfig wrong in IPv6 only env
21653b1 
Server address in whereabouts.kubeconfig file has wrong format when the service
has IPv6 address. The IPv6 server address must be wrapped in '[]'.
@s1061123
Change error message
eeca015 
This changes change error message in case of kubeconfig non-existence
at loading IPAM config to cause appropreate error message when kubeconfig
is not exist in case of kubernetes CRD mode.
@dougbtv
Merge pull request #54 from s1061123/fix/check_kubeconfig_stat
71f788c 
Change error message
@s1061123
Specifiy image repo URL explicitly
23ba228 
This fix supplies domain for container image repo because
in some runtime configuration, 'docker.io' is not specified as
default container repository url.
@dougbtv
Merge pull request #56 from s1061123/add/fix-image-url
1e071f2 
Specifiy image repo URL explicitly
@dougbtv
Fixing wrong DNS-1123 name for some IPv6 addresses
8eea580
@dougbtv
Merge pull request #61 from dougbtv/ipv6-dns-1123-bugfix
04ed52b 
Fixing wrong DNS-1123 name for some IPv6 addresses
@dougbtv
Add a more meaningful error for invalid CIDR
2d28b21
@dougbtv
Merge pull request #66 from dougbtv/fix-invalid-cidr-error
8b1d7dd 
Add a more meaningful error for invalid CIDR
@dougbtv
Adds the missing error/log/warn methods to the install-cni.sh
1f9fe7f
@dougbtv
Merge pull request #47 from ohamada/fix/confipv6
9eaeacc 
whereabouts.kubeconfig wrong in IPv6 only env
@dougbtv
Merge pull request #67 from dougbtv/update-install-cni-sh
0fed782 
Adds the missing error/log/warn methods to the install-cni.sh
@xagent003 @dougbtv
Create Whereabouts flatfile config by default
57008a9
@dougbtv
[autoconfig-by-default] Updates install script /host directory, refac…
7057d86 
…tors README for auto config, also preps readme for deprecating etcd
@shivakumargn @dougbtv
Excluded subnet handling for ipv6
ba456d2 
Excluded subnets was handled for ipv4. This fix handles ipv6 as well.

Fixes dougbtv/whereabouts#71

Adds test to check for excluding IPv6 addresses
@dougbtv
Merge pull request #73 from dougbtv/develop
f911376 
Includes fix for excluding IPv6 ranges as well as unit test
@dougbtv
Removes error when deallocating IP errors out, instead just warns.
36bc6e1
@dougbtv
Merge pull request #74 from dougbtv/stuck-creating
a5227d6 
Removes error when deallocating IP errors out, instead just warns.
@dougbtv
Merge pull request #69 from dougbtv/autoconfig-by-default
e30a59a 
Reduces required parameters by introducing flatfile configuration by default
@dougbtv
Logic for IPv6 assignment should not omit the broadcast addresses
e88ef05 
This removes the logic that was IPv4 based for removing the broadcast address.

[IPv6 does not implement broadcast](https://en.wikipedia.org/wiki/IPv6_address#Addressing_methods).

It also adds a unit test to validate that, as well as updates some checks which wrongly assumed the broadcast address omission.
@dougbtv
Merge pull request #77 from dougbtv/fix-ipv6-broadcast-omission
8996724 
Logic for IPv6 assignment should not omit the broadcast addresses
@dougbtv
The first example can drop the optional parameters
89790a8 
This removes the (now default) kubernetes data store from the first CNI config example.
@dougbtv
Merge pull request #81 from dougbtv/update-example
d1cc539 
The first example can drop the optional parameters
@jdambly-ns
updated readme with instructions on how to install using helm3
ee452f1
@dougbtv
Merge pull request #82 from jdambly/helm-chart
f13aeef 
updated readme with instructions on how to install using helm3
@dougbtv
README incorrectly stated Whereabouts requires three parameters
34e151b 
It only requires two. Also updated the paragraph there for better context, added IPv6 subnet calculator link.
@dougbtv
Merge pull request #90 from dougbtv/doc-bug-required-params
daf5995 
README incorrectly stated Whereabouts requires three parameters
@dougbtv
[travis] Adds a login so we can pull images from the registry
6feeed2
@dougbtv
Merge pull request #91 from dougbtv/update-travis-docker-login
96ef85c 
[travis] Adds a login so we can pull images from the registry
@s1061123
Change CI pipeline from travis CI to github actions
0f0a9e5 
This change replaces travis CI with github actions.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@dougbtv: This pull request references Bugzilla bug 1990113, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1990115 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1990115 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

Bug 1990113: Syncs with upstream for leader election [backport 4.8]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@dougbtv: This pull request references Bugzilla bug 1990113, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1990115 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1990115 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

Bug 1990113: Syncs with upstream for leader election [backport 4.8]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and squeed August 24, 2021 18:30
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@s1061123
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021
@dougbtv
Copy link
Member Author

dougbtv commented Aug 26, 2021

NOTE: openshift/cluster-network-operator#1185 must be merged before or at the same time as this, otherwise, it will likely cause a regression.

@jupierce
Copy link
Contributor

/hold
patch-manager automation could approve and merge. I suggest keeping this hold until openshift/cluster-network-operator#1185 is in.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2021
@yingwang-0320
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 8, 2021
@yingwang-0320
Copy link

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123, yingwang-0320

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dougbtv dougbtv mentioned this pull request Sep 9, 2021
Merged
@mfojtik
Copy link
Member

mfojtik commented Sep 10, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@dougbtv
Copy link
Member Author

dougbtv commented Sep 10, 2021

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2021
@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2afc6d1 into release-4.8 Sep 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2021

@dougbtv: All pull requests linked via external trackers have merged:

Bugzilla bug 1990113 has been moved to the MODIFIED state.

In response to this:

Bug 1990113: Syncs with upstream for leader election [backport 4.8]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@squeed squeed Awaiting requested review from squeed

Assignees

@s1061123 s1061123

@yingwang-0320 yingwang-0320

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet