Bug 1965268: Syncs with upstream for leader election [backport 4.7] #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server address in whereabouts.kubeconfig file has wrong format when the service has IPv6 address. The IPv6 server address must be wrapped in '[]'.
This changes change error message in case of kubeconfig non-existence at loading IPAM config to cause appropreate error message when kubeconfig is not exist in case of kubernetes CRD mode.
Change error message
This fix supplies domain for container image repo because in some runtime configuration, 'docker.io' is not specified as default container repository url.
Specifiy image repo URL explicitly
Fixing wrong DNS-1123 name for some IPv6 addresses
Add a more meaningful error for invalid CIDR
whereabouts.kubeconfig wrong in IPv6 only env
Adds the missing error/log/warn methods to the install-cni.sh
…tors README for auto config, also preps readme for deprecating etcd
Excluded subnets was handled for ipv4. This fix handles ipv6 as well. Fixes dougbtv/whereabouts#71 Adds test to check for excluding IPv6 addresses
Includes fix for excluding IPv6 ranges as well as unit test
Removes error when deallocating IP errors out, instead just warns.
Reduces required parameters by introducing flatfile configuration by default
This removes the logic that was IPv4 based for removing the broadcast address. [IPv6 does not implement broadcast](https://en.wikipedia.org/wiki/IPv6_address#Addressing_methods). It also adds a unit test to validate that, as well as updates some checks which wrongly assumed the broadcast address omission.
Logic for IPv6 assignment should not omit the broadcast addresses
This removes the (now default) kubernetes data store from the first CNI config example.
The first example can drop the optional parameters
updated readme with instructions on how to install using helm3
It only requires two. Also updated the paragraph there for better context, added IPv6 subnet calculator link.
README incorrectly stated Whereabouts requires three parameters
[travis] Adds a login so we can pull images from the registry
This change replaces travis CI with github actions.
|
/retest |
The hack/build-go.sh script is modified to pass version information during the build through LDFLAGS, which is a pretty standard technique. This information can then be used to report the version of the whereabouts CNI plugin at runtime; before this change the plugin would just print "TODO".
readme: fix yaml paths
Add support for CNI version
When context timeout occurs while updating the ip pool CRD, error is not returned but allocated IP is returned. This leads to duplicate IP allocation. This change fixes the above by returning error. Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@est.tech>
Enable LE config attribute 'ReleaseOnCancel' which will cause release of the associated lock when LE ends. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
The binaries (built for amd64, arm64 and arm) are uploaded using a Github workflow every time a new Github release is created. This simplifies consumption of these binaries by other projects, and creates an "official" build. Signed-off-by: Antonin Bas <abas@vmware.com>
…elease-asset Upload whereabouts binary as release asset
During scale testing, we found that if an instance of whereabouts did not accomplish its task within a period of time, the kubelet spawned an additional whereabouts instance and the initial instance remained active. For pod creation, the Kubelet will try to start a pod and wait for ~8 minutes before attempting to kill it. See kubelets "runPod" function. For pod deletion, kubelet will attempt to kill a pod and if it fails it will attempt after one minute one more time. Unable to see this in kubelet code but observed it using K8 1.22. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
propagate context timeout error
Release lease lock when LE ends
Add total Add/Del timeout
Test cases are simple and check that: * IPs seen in IP pool are what is assigned to pods. * No stale IPs in IP pool following test run. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Add E2E test cases and execute with GH workflow
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-urgent
|
@dougbtv: This pull request references Bugzilla bug 1965268, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knobunc
added
the
cherry-pick-approved
|
@dougbtv: All pull requests linked via external trackers have merged: Bugzilla bug 1965268 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.