Bug 2028968: Whereabouts should reconcile IP addresses [backport 4.6] #80

dougbtv · 2021-12-20T21:42:06Z

This catches up to release v0.5.1 to integrate all IP reconciliation fixes.

Server address in whereabouts.kubeconfig file has wrong format when the service has IPv6 address. The IPv6 server address must be wrapped in '[]'.

This changes change error message in case of kubeconfig non-existence at loading IPAM config to cause appropreate error message when kubeconfig is not exist in case of kubernetes CRD mode.

Change error message

This fix supplies domain for container image repo because in some runtime configuration, 'docker.io' is not specified as default container repository url.

Specifiy image repo URL explicitly

Fixing wrong DNS-1123 name for some IPv6 addresses

Add a more meaningful error for invalid CIDR

whereabouts.kubeconfig wrong in IPv6 only env

Adds the missing error/log/warn methods to the install-cni.sh

…tors README for auto config, also preps readme for deprecating etcd

Excluded subnets was handled for ipv4. This fix handles ipv6 as well. Fixes dougbtv/whereabouts#71 Adds test to check for excluding IPv6 addresses

Includes fix for excluding IPv6 ranges as well as unit test

Removes error when deallocating IP errors out, instead just warns.

Reduces required parameters by introducing flatfile configuration by default

This removes the logic that was IPv4 based for removing the broadcast address. [IPv6 does not implement broadcast](https://en.wikipedia.org/wiki/IPv6_address#Addressing_methods). It also adds a unit test to validate that, as well as updates some checks which wrongly assumed the broadcast address omission.

Logic for IPv6 assignment should not omit the broadcast addresses

This removes the (now default) kubernetes data store from the first CNI config example.

The first example can drop the optional parameters

updated readme with instructions on how to install using helm3

It only requires two. Also updated the paragraph there for better context, added IPv6 subnet calculator link.

README incorrectly stated Whereabouts requires three parameters

[travis] Adds a login so we can pull images from the registry

This change replaces travis CI with github actions.

openshift-bot · 2022-01-26T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-26T01:01:03Z

@openshift-bot: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
expected dependent Bugzilla bug 2028967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-27T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-27T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 2028967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-28T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-28T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-29T01:01:21Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-29T01:01:26Z

@openshift-bot: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-30T01:01:02Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-30T01:01:10Z

@openshift-bot: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-31T01:01:03Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-01-31T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-01T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-01T01:01:03Z

@openshift-bot: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-02-02T01:00:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-02-02T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv · 2022-02-02T19:25:17Z

/bugzilla refresh

openshift-ci · 2022-02-02T19:25:23Z

@dougbtv: This pull request references Bugzilla bug 2028968, which is invalid:

expected dependent Bugzilla bug 2028963 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2028964 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2028966 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv · 2022-02-02T19:26:41Z

/bugzilla refresh

openshift-ci · 2022-02-02T19:26:49Z

@dougbtv: This pull request references Bugzilla bug 2028968, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2028967 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2028967 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv · 2022-02-02T19:26:59Z

/label backport-risk-assessed

weliang1 · 2022-02-03T16:25:21Z

/label qe-approved

weliang1 · 2022-02-03T16:26:45Z

/label cherry-pick-approved

openshift-ci · 2022-02-03T16:28:28Z

@dougbtv: All pull requests linked via external trackers have merged:

openshift/whereabouts-cni#80

Bugzilla bug 2028968 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ohamada and others added 30 commits July 16, 2020 18:10

whereabouts.kubeconfig wrong in IPv6 only env

21653b1

Server address in whereabouts.kubeconfig file has wrong format when the service has IPv6 address. The IPv6 server address must be wrapped in '[]'.

Change error message

eeca015

This changes change error message in case of kubeconfig non-existence at loading IPAM config to cause appropreate error message when kubeconfig is not exist in case of kubernetes CRD mode.

Merge pull request #54 from s1061123/fix/check_kubeconfig_stat

71f788c

Change error message

Specifiy image repo URL explicitly

23ba228

This fix supplies domain for container image repo because in some runtime configuration, 'docker.io' is not specified as default container repository url.

Merge pull request #56 from s1061123/add/fix-image-url

1e071f2

Specifiy image repo URL explicitly

Fixing wrong DNS-1123 name for some IPv6 addresses

8eea580

Merge pull request #61 from dougbtv/ipv6-dns-1123-bugfix

04ed52b

Fixing wrong DNS-1123 name for some IPv6 addresses

Add a more meaningful error for invalid CIDR

2d28b21

Merge pull request #66 from dougbtv/fix-invalid-cidr-error

8b1d7dd

Add a more meaningful error for invalid CIDR

Adds the missing error/log/warn methods to the install-cni.sh

1f9fe7f

Merge pull request #47 from ohamada/fix/confipv6

9eaeacc

whereabouts.kubeconfig wrong in IPv6 only env

Merge pull request #67 from dougbtv/update-install-cni-sh

0fed782

Adds the missing error/log/warn methods to the install-cni.sh

Create Whereabouts flatfile config by default

57008a9

[autoconfig-by-default] Updates install script /host directory, refac…

7057d86

…tors README for auto config, also preps readme for deprecating etcd

Excluded subnet handling for ipv6

ba456d2

Excluded subnets was handled for ipv4. This fix handles ipv6 as well. Fixes dougbtv/whereabouts#71 Adds test to check for excluding IPv6 addresses

Merge pull request #73 from dougbtv/develop

f911376

Includes fix for excluding IPv6 ranges as well as unit test

Removes error when deallocating IP errors out, instead just warns.

36bc6e1

Merge pull request #74 from dougbtv/stuck-creating

a5227d6

Removes error when deallocating IP errors out, instead just warns.

Merge pull request #69 from dougbtv/autoconfig-by-default

e30a59a

Reduces required parameters by introducing flatfile configuration by default

Merge pull request #77 from dougbtv/fix-ipv6-broadcast-omission

8996724

Logic for IPv6 assignment should not omit the broadcast addresses

The first example can drop the optional parameters

89790a8

This removes the (now default) kubernetes data store from the first CNI config example.

Merge pull request #81 from dougbtv/update-example

d1cc539

The first example can drop the optional parameters

updated readme with instructions on how to install using helm3

ee452f1

Merge pull request #82 from jdambly/helm-chart

f13aeef

updated readme with instructions on how to install using helm3

README incorrectly stated Whereabouts requires three parameters

34e151b

It only requires two. Also updated the paragraph there for better context, added IPv6 subnet calculator link.

Merge pull request #90 from dougbtv/doc-bug-required-params

daf5995

README incorrectly stated Whereabouts requires three parameters

[travis] Adds a login so we can pull images from the registry

6feeed2

Merge pull request #91 from dougbtv/update-travis-docker-login

96ef85c

[travis] Adds a login so we can pull images from the registry

Change CI pipeline from travis CI to github actions

0f0a9e5

This change replaces travis CI with github actions.

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 2, 2022

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 2, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 2, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 3, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 3, 2022

openshift-merge-robot merged commit f8b4408 into release-4.6 Feb 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2028968: Whereabouts should reconcile IP addresses [backport 4.6] #80

Bug 2028968: Whereabouts should reconcile IP addresses [backport 4.6] #80

dougbtv commented Dec 20, 2021

openshift-bot commented Jan 26, 2022

openshift-ci bot commented Jan 26, 2022

openshift-bot commented Jan 27, 2022

openshift-ci bot commented Jan 27, 2022

openshift-bot commented Jan 28, 2022

openshift-ci bot commented Jan 28, 2022

openshift-bot commented Jan 29, 2022

openshift-ci bot commented Jan 29, 2022

openshift-bot commented Jan 30, 2022

openshift-ci bot commented Jan 30, 2022

openshift-bot commented Jan 31, 2022

openshift-ci bot commented Jan 31, 2022

openshift-bot commented Feb 1, 2022

openshift-ci bot commented Feb 1, 2022

openshift-bot commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

dougbtv commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

dougbtv commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

dougbtv commented Feb 2, 2022

weliang1 commented Feb 3, 2022

weliang1 commented Feb 3, 2022

openshift-ci bot commented Feb 3, 2022

Bug 2028968: Whereabouts should reconcile IP addresses [backport 4.6] #80

Bug 2028968: Whereabouts should reconcile IP addresses [backport 4.6] #80

Conversation

dougbtv commented Dec 20, 2021

openshift-bot commented Jan 26, 2022

openshift-ci bot commented Jan 26, 2022

openshift-bot commented Jan 27, 2022

openshift-ci bot commented Jan 27, 2022

openshift-bot commented Jan 28, 2022

openshift-ci bot commented Jan 28, 2022

openshift-bot commented Jan 29, 2022

openshift-ci bot commented Jan 29, 2022

openshift-bot commented Jan 30, 2022

openshift-ci bot commented Jan 30, 2022

openshift-bot commented Jan 31, 2022

openshift-ci bot commented Jan 31, 2022

openshift-bot commented Feb 1, 2022

openshift-ci bot commented Feb 1, 2022

openshift-bot commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

dougbtv commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

dougbtv commented Feb 2, 2022

openshift-ci bot commented Feb 2, 2022

dougbtv commented Feb 2, 2022

weliang1 commented Feb 3, 2022

weliang1 commented Feb 3, 2022

openshift-ci bot commented Feb 3, 2022