Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] WINC-1047: Add support for Windows Server 2022 in AWS #1629

Merged

Conversation

aravindhp
Copy link
Contributor

Update to openshift/ovn-kubernetes@db0dbad which will pick up the fix for OCPBUGS-13170. The fix will prevent hybrid-overlay from overwriting the non-persistent routes for the metadata endpoint on AWS Windows Server 2022 instances. Once this PR merges, a follow up PR to the release repo will be required to actually start testing Windows Server 2022 on 4.13 AWS clusters.

Update to openshift/ovn-kubernetes@db0dbad

This commit was generated using hack/update_submodules.sh
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 24, 2023

@aravindhp: This pull request references WINC-805 which is a valid jira issue.

In response to this:

Update to openshift/ovn-kubernetes@db0dbad which will pick up the fix for OCPBUGS-13170. The fix will prevent hybrid-overlay from overwriting the non-persistent routes for the metadata endpoint on AWS Windows Server 2022 instances. Once this PR merges, a follow up PR to the release repo will be required to actually start testing Windows Server 2022 on 4.13 AWS clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@aravindhp
Copy link
Contributor Author

/approve cancel

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@sebsoto
Copy link
Contributor

sebsoto commented May 24, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@aravindhp
Copy link
Contributor Author

aravindhp commented May 24, 2023

/retitle [release-4.13] WINC-1047: Add support for Windows Server 2022 in AWS

@openshift-ci openshift-ci bot changed the title [release-4.13] WINC-805: Add support for Windows Server 2022 in AWS [release-4.13] WINC-1047: Add support for Windows Server 2022 in AWS May 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 24, 2023

@aravindhp: This pull request references WINC-1047 which is a valid jira issue.

In response to this:

Update to openshift/ovn-kubernetes@db0dbad which will pick up the fix for OCPBUGS-13170. The fix will prevent hybrid-overlay from overwriting the non-persistent routes for the metadata endpoint on AWS Windows Server 2022 instances. Once this PR merges, a follow up PR to the release repo will be required to actually start testing Windows Server 2022 on 4.13 AWS clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp aravindhp marked this pull request as ready for review May 25, 2023 19:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2023
@mtnbikenc
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD de07666 and 2 for PR HEAD 9dcbed5 in total

@aravindhp
Copy link
Contributor Author

/retest-required

1 similar comment
@mtnbikenc
Copy link
Member

/retest-required

@mtnbikenc
Copy link
Member

vsphere-e2e-operator took nearly two hours to acquire a lease. It will probably fail and require another retest.

@mtnbikenc
Copy link
Member

/retest-required

@mtnbikenc
Copy link
Member

Seen this error twice, might be something to investigate as mentioned in Slack.

    create_test.go:203: 
        	Error Trace:	/go/src/github.com/openshift/windows-machine-config-operator/test/e2e/create_test.go:203
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestWMCO/create/Creation/ConfigMap_controller/VM_is_configured_by_ConfigMap_controller
        	Messages:   	Windows node creation failed

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2023

@aravindhp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2194d57 into openshift:release-4.13 May 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants