Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-27503: Use DSR load balancing in kube-proxy #2024

Merged
merged 5 commits into from Jan 24, 2024
Merged

[release-4.15] OCPBUGS-27503: Use DSR load balancing in kube-proxy #2024

merged 5 commits into from Jan 24, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2006

/assign sebsoto

@sebsoto
Change sourceVIP used for kube-proxy
ab9a169 
Changes the method of choosing a sourceVIP for kube-proxy to be in line
with Microsoft guidelines. The HNS endpoint for the VIPEndpoint
interface is no longer needed.
@sebsoto
Switch to DSR load balancing
f242d7c 
The port reservation logic in kube-proxy's dsr mode is better tested.
Without using DSR, packet loss was being seen by on Windows Server 2019.
@sebsoto
Add Windows Exporter port to firewall
d055ab7 
Explicity allows incoming traffic for the Windows Exporter metrics
server running on Windows nodes.
@sebsoto
Refactor machine approver scaling
a7c4ee9 
Adds new function to help scale up/down the cluster machine approver
deployment.
@sebsoto
Fix upgrade test for Machine recreation
e07b57f 
Adjusts the update test ensure it works when Machines are recreated as
part of an upgrade. This will happen when the userdata is changed
between two releases. The existing problems are that the Cluster Machine
Approver needs to be scaled so CSRs can be approved, and that storage
workloads which are being used to test across upgrades need to not be
assigned a Node affinity. If there is an affinity on the Node that is
replaced, the workload will not be able to be rescheduled.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 22, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-26761 has been cloned as Jira Issue OCPBUGS-27503. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-27503: Use DSR load balancing in kube-proxy

In response to this:

This is an automated cherry-pick of #2006

/assign sebsoto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mansikulkarni96
Copy link
Member

/approve

@mansikulkarni96
Copy link
Member

/lgtm

@mtnbikenc
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2024
@openshift-ci-robot
Copy link

@mtnbikenc: This pull request references Jira Issue OCPBUGS-26761, which is invalid:

  • expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.16.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • expected Jira Issue OCPBUGS-26761 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtnbikenc
Copy link
Member

/retitle [release-4.15] OCPBUGS-27503: Use DSR load balancing in kube-proxy

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-26761: Use DSR load balancing in kube-proxy [release-4.15] OCPBUGS-27503: Use DSR load balancing in kube-proxy Jan 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 22, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-27503, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26761 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-26761 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @rrasouli

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2006

/assign sebsoto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 22, 2024
@openshift-ci openshift-ci bot requested a review from rrasouli January 22, 2024 17:13
@mtnbikenc
Copy link
Member

/test remaining-required

@mansikulkarni96
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mansikulkarni96, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@mansikulkarni96
Copy link
Member

/lgtm

1 similar comment
@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5147e86 and 2 for PR HEAD e07b57f in total

@mtnbikenc
Copy link
Member

platform-none-vsphere-e2e-operator job blocked by:
openshift/release Use standard Windows server 2022 image
openshift/wmco [test] Open SMB port when creating share

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 971f3ed and 1 for PR HEAD e07b57f in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9581032 into openshift:release-4.15 Jan 24, 2024
17 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27503: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27503 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2006

/assign sebsoto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebsoto
Copy link
Contributor

sebsoto commented Jan 25, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Author

@sebsoto: #2024 failed to apply on top of branch "release-4.14":

Applying: Change sourceVIP used for kube-proxy
Applying: Switch to DSR load balancing
Applying: Add Windows Exporter port to firewall
Applying: Refactor machine approver scaling
Applying: Fix upgrade test for Machine recreation
Using index info to reconstruct a base tree...
M	test/e2e/storage_test.go
M	test/e2e/upgrade_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/upgrade_test.go
CONFLICT (content): Merge conflict in test/e2e/upgrade_test.go
Auto-merging test/e2e/storage_test.go
CONFLICT (content): Merge conflict in test/e2e/storage_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0005 Fix upgrade test for Machine recreation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sebsoto sebsoto mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrasouli rrasouli Awaiting requested review from rrasouli

Assignees

@sebsoto sebsoto

@mansikulkarni96 mansikulkarni96

@jrvaldes jrvaldes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @mansikulkarni96 @mtnbikenc @jrvaldes @sebsoto