WINC-649: [wmco] Change BYOH annotation to a label #549
Conversation
openshift-ci
bot
added
the
approved
|
/approve cancel |
openshift-ci
bot
removed
the
approved
|
/lgtm |
|
LGTM |
controllers/configmap_controller.go
Outdated
| @@ -219,7 +219,7 @@ func (r *ConfigMapReconciler) ensureInstancesAreUpToDate(instances []*instances. | |||
| func (r *ConfigMapReconciler) deconfigureInstances(instances []*instances.InstanceInfo, nodes *core.NodeList) error { | |||
| for _, node := range nodes.Items { | |||
| // Only looking at BYOH nodes | |||
| if _, present := node.Annotations[BYOHAnnotation]; !present { | |||
| if _, present := node.GetLabels()[BYOHLabel]; !present { | |||
There was a problem hiding this comment.
I suggest updating the filter when you are getting the list of nodes.
controllers/configmap_controller.go
Outdated
| nodes := &core.NodeList{} | ||
| if err := r.client.List(ctx, nodes); err != nil { | ||
| if err := r.client.List(ctx, nodes, client.MatchingLabels{BYOHLabel: "true"}); err != nil { |
There was a problem hiding this comment.
To be on the safe side, the Windows label should also be added.
| // Only looking at BYOH nodes | ||
| if _, present := node.Annotations[BYOHAnnotation]; !present { | ||
| continue | ||
| } |
There was a problem hiding this comment.
This implies the method doc needs to be updated to state that that input nodes are assumed to be Windows BYOH
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
|
Thanks for working on this @sebsoto |
Changes the BYOH annotation to a label to allow for easier selection of BYOH nodes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, jrvaldes, saifshaikh48 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
Machine provisioning flake, not an issue on our side |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/cherry-pick community-4.8 |
|
@sebsoto: new pull request created: #563 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.8 |
|
@mansikulkarni96: new pull request created: #606 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes the BYOH annotation to a label to allow for easier selection of
BYOH nodes.