Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] WINC-649: [wmco] Change BYOH annotation to a label #606

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #549

/assign mansikulkarni96

Changes the BYOH annotation to a label to allow for easier selection of
BYOH nodes.
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
Copy link
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sebsoto
Copy link
Contributor

sebsoto commented Aug 17, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, openshift-cherrypick-robot, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@openshift-ci openshift-ci bot merged commit b32afde into openshift:release-4.8 Aug 17, 2021
mansikulkarni96 pushed a commit to mansikulkarni96/windows-machine-config-operator that referenced this pull request Aug 7, 2023
…penshift-cherrypick-robot/cherry-pick-549-to-release-4.8

Updated upstream source commit.
Commit details follow:

Project: https://github.com/openshift/windows-machine-config-operator.git
Branch:  release-4.8
Commit:  b32afde
Author:  openshift-ci[bot]
Date:    Tue, 17 Aug 2021 16:45:38 +0000

    Merge pull request openshift#606 from openshift-cherrypick-robot/cherry-pick-549-to-release-4.8

    [release-4.8] WINC-649: [wmco] Change BYOH annotation to a label

Additional included commits:
  faeecd7, 37c85a5, b41977d, 83597c9, a4d25fb, 6a715e0

automerge: yes
x-md5: d73bc6c837a787aaab64b0d9300a1529
Change-Id: Ica9e97284069956e304bd5fc2b0d39e80e3ced6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants