Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINC-607: [build] Install jq in CI Dockerfile #900

Merged
merged 1 commit into from Feb 23, 2022
Merged

WINC-607: [build] Install jq in CI Dockerfile #900

merged 1 commit into from Feb 23, 2022

Conversation

jrvaldes
Copy link
Contributor

@jrvaldes jrvaldes commented Feb 9, 2022 •
edited

This PR Install jq in CI Dockerfile. jqrequirement was introduced in c1fb113.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2022
@jrvaldes jrvaldes mentioned this pull request Feb 9, 2022
Merged
@jrvaldes jrvaldes marked this pull request as ready for review February 9, 2022 20:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2022
@openshift-ci openshift-ci bot requested a review from sebsoto February 9, 2022 20:08
@selansen
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
sebsoto
sebsoto requested changes Feb 10, 2022
View reviewed changes
build/Dockerfile.ci Outdated
@@ -8,7 +8,8 @@ LABEL stage=build
WORKDIR /build/

# dos2unix is needed to build CNI plugins
RUN yum install -y dos2unix
# jq is needed in e2e test script
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you state specifically what it is needed for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in e755824

@jrvaldes
[build] Install jq in CI Dockerfile
e755824 
`jq` is needed in e2e test script to count the number of data items
in the windows-instances ConfigMap.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@jrvaldes jrvaldes changed the title [build] Install jq in CI Dockerfile WINC-607: [build] Install jq in CI Dockerfile Feb 10, 2022
@jrvaldes
Copy link
Contributor Author

/cherry-pick release-4.10

@openshift-cherrypick-robot
Copy link

@jrvaldes: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes
Copy link
Contributor Author

/cherry-pick community-4.9

@openshift-cherrypick-robot
Copy link

@jrvaldes: once the present PR merges, I will cherry-pick it on top of community-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick community-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes
Copy link
Contributor Author

/cherry-pick release-4.9

@openshift-cherrypick-robot
Copy link

@jrvaldes: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes
Copy link
Contributor Author

/cherry-pick community-4.8

@openshift-cherrypick-robot
Copy link

@jrvaldes: once the present PR merges, I will cherry-pick it on top of community-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick community-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes
Copy link
Contributor Author

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link

@jrvaldes: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saifshaikh48
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
selansen
selansen approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@selansen selansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@selansen
Copy link
Contributor

Did we get any update from dptp team for the below issue?
error: build error: error building at STEP "RUN yum install -y dos2unix jq": error while running runtime: exit status 1

@jrvaldes
Copy link
Contributor Author

/test azure-e2e-operator

machine creation timeout

@jrvaldes
Copy link
Contributor Author

/test vsphere-e2e-operator

package repository unavailable

@jrvaldes
Copy link
Contributor Author

Did we get any update from dptp team for the below issue? error: build error: error building at STEP "RUN yum install -y dos2unix jq": error while running runtime: exit status 1

Nope. Other jobs passed.

@jrvaldes
Copy link
Contributor Author

/test images

@sebsoto
Copy link
Contributor

sebsoto commented Feb 23, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, sebsoto, selansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jrvaldes
Copy link
Contributor Author

/test vsphere-e2e-operator

@jrvaldes
Copy link
Contributor Author

/test vsphere-e2e-operator

release image creation failed.

This was referenced Feb 23, 2022
Closed
Merged
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2098547 into openshift:master Feb 23, 2022
@openshift-cherrypick-robot
Copy link

@jrvaldes: #900 failed to apply on top of branch "release-4.9":

Applying: Install jq in CI Dockerfile
Using index info to reconstruct a base tree...
M	build/Dockerfile.ci
Falling back to patching base and 3-way merge...
Auto-merging build/Dockerfile.ci
CONFLICT (content): Merge conflict in build/Dockerfile.ci
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Install jq in CI Dockerfile
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jrvaldes: #900 failed to apply on top of branch "community-4.8":

Applying: Install jq in CI Dockerfile
Using index info to reconstruct a base tree...
M	build/Dockerfile.ci
Falling back to patching base and 3-way merge...
Auto-merging build/Dockerfile.ci
CONFLICT (content): Merge conflict in build/Dockerfile.ci
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Install jq in CI Dockerfile
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick community-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jrvaldes: #900 failed to apply on top of branch "release-4.8":

Applying: Install jq in CI Dockerfile
Using index info to reconstruct a base tree...
M	build/Dockerfile.ci
Falling back to patching base and 3-way merge...
Auto-merging build/Dockerfile.ci
CONFLICT (content): Merge conflict in build/Dockerfile.ci
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Install jq in CI Dockerfile
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 23, 2022
Closed
@openshift-cherrypick-robot
Copy link

@jrvaldes: new pull request created: #931

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jrvaldes: #900 failed to apply on top of branch "community-4.9":

Applying: Install jq in CI Dockerfile
Using index info to reconstruct a base tree...
M	build/Dockerfile.ci
Falling back to patching base and 3-way merge...
Auto-merging build/Dockerfile.ci
CONFLICT (content): Merge conflict in build/Dockerfile.ci
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Install jq in CI Dockerfile
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick community-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrvaldes jrvaldes mentioned this pull request Feb 24, 2022
Merged
@jrvaldes jrvaldes deleted the install-jq-ci-image branch March 17, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selansen selansen selansen approved these changes

@aravindhp aravindhp Awaiting requested review from aravindhp

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@selansen selansen

@saifshaikh48 saifshaikh48

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jrvaldes @selansen @openshift-cherrypick-robot @saifshaikh48 @sebsoto @openshift-bot @openshift-merge-robot