New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.10] WINC-607: Add support for platform=none in e2e test suite (Cont.) #937
[release-4.10] WINC-607: Add support for platform=none in e2e test suite (Cont.) #937
Conversation
- Disable the application ingress load balancer test for platform=none - Use t.Skipf() to ignore the test with better logging - Move the check to the beginning of the test to avoid the creation of the WindowsWebServer deployment Follow-up to 91ecc9d
This commit skips the MachineSet update in the Windows node deletion test if no MachineSet is found with the Windows label. This is a corner case for platform-agnostic infrastructure and e2e tests executions where no instances are configured via MachineController, for example: `hack/run-ci-e2e-test.sh -m 0`.
`jq` is needed in e2e test script to count the number of data items in the windows-instances ConfigMap.
/retest |
/lgtm |
/approve |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…penshift-cherrypick-robot/cherry-pick-896-to-release-4.10 Updated upstream source commit. Commit details follow: Project: https://github.com/openshift/windows-machine-config-operator.git Branch: release-4.10 Commit: 3a3ec53 Author: OpenShift Merge Robot Date: Thu, 3 Mar 2022 03:37:30 -0500 Merge pull request openshift#937 from openshift-cherrypick-robot/cherry-pick-896-to-release-4.10 [release-4.10] WINC-607: Add support for platform=none in e2e test suite (Cont.) Referenced RedHat JIRA issue: WINC-607 automerge: yes x-md5: 7811959662bbbbd6dc41d2a4fab49ad3 Change-Id: I2c68a5e4fb0dec2385fdc712ce0f99cb7e942ae9
This is an automated cherry-pick of #896
/assign jrvaldes