Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINC-607: Require platform=none job in 4.10 presubmits #26591

Merged
merged 1 commit into from Mar 4, 2022
Merged

WINC-607: Require platform=none job in 4.10 presubmits #26591

merged 1 commit into from Mar 4, 2022

Conversation

jrvaldes
Copy link
Contributor

This commit sets the platform=none job to always run, following the
approach introduced in 19f53ec

@jrvaldes
wmco: Require platform=none job in 4.10 presubmits
6931eff 
This commit sets the platform=none job to always run, following the
approach introduced in 19f53ec
@jrvaldes
Copy link
Contributor Author

/hold

Depends on:

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2022
@jrvaldes jrvaldes changed the title wmco: Require platform=none job in 4.10 presubmits WINC-607: Require platform=none job in 4.10 presubmits Feb 25, 2022
@sebsoto
Copy link
Contributor

sebsoto commented Mar 2, 2022

/approve

@sebsoto
Copy link
Contributor

sebsoto commented Mar 2, 2022

/hold cancel
All required PRs have merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@sebsoto
Copy link
Contributor

sebsoto commented Mar 2, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@sebsoto
Copy link
Contributor

sebsoto commented Mar 2, 2022

/hold cancel

@sebsoto
Copy link
Contributor

sebsoto commented Mar 2, 2022

/hold

@sebsoto
Copy link
Contributor

sebsoto commented Mar 2, 2022

openshift/windows-machine-config-operator#937
needs to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@selansen
Copy link

selansen commented Mar 3, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, mansikulkarni96, sebsoto, selansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mansikulkarni96
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f01b2db into openshift:master Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@jrvaldes: Updated the job-config-4.10 configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-windows-machine-config-operator-release-4.10-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.10-presubmits.yaml

In response to this:

This commit sets the platform=none job to always run, following the
approach introduced in 19f53ec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mansikulkarni96 mansikulkarni96 mentioned this pull request Mar 4, 2022
Merged
@jrvaldes jrvaldes deleted the winc-607-release-4.10-platform-none-vsphere-e2e-operator-test-mandatory branch March 8, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@selansen selansen Awaiting requested review from selansen

Assignees

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
5 participants
@jrvaldes @sebsoto @mansikulkarni96 @selansen @openshift-merge-robot