[community-4.9] WINC-607: Add support for platform=none in e2e test suite #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add platform=none as new cloud provider in WMCO e2e test suite - Add a check in ConfigMap controller test to avoid the creation of Windows instances via machineSet for platform-agnostic infrastructure - Introduce a function to validate windows-instances ConfigMap - Add a new step in run-ci-e2e-test.sh script to create the windows-instances configMap once the operator deployment process is complete. - Add a new Makefile target to test BYOH in platform=none, where the number of Windows instances created by MachineSet is fixed to 0. (cherry picked from commit c1fb113)
This commit updates the mapi api used in the none.go file from github.com/openshift/api/machine/v1beta1 to github.com/openshift/machine-api-operator/pkg/apis/machine/v1beta1 complying with the location of api for the community-4.9 branch.
This commit adds section in HACKING.md to describe the process of running the e2e tests on a platform-agnostic infrastructure. (cherry picked from commit cfdded1)
(cherry picked from commit 79434fe)
mansikulkarni96
changed the title
|
@mansikulkarni96: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mansikulkarni96, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #858 to fix the location of openshift/mapi api used in all branches before release-4.10.