Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[community-4.9] WINC-607: Add support for platform=none in e2e test suite #955

Closed
wants to merge 3 commits into from
Closed

[community-4.9] WINC-607: Add support for platform=none in e2e test suite #955

wants to merge 3 commits into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #858

/assign mansikulkarni96

@jrvaldes
Add support for platform=none
ff6598a 
- Add platform=none as new cloud provider in WMCO e2e test suite
- Add a check in ConfigMap controller test to avoid the creation of
  Windows instances via machineSet for platform-agnostic infrastructure
- Introduce a function to validate windows-instances ConfigMap
- Add a new step in run-ci-e2e-test.sh script to create the windows-instances
  configMap once the operator deployment process is complete.
- Add a new Makefile target to test BYOH in platform=none, where the number of
  Windows instances created by MachineSet is fixed to 0.
@jrvaldes
Run e2e tests in platform=none
2c4b153 
This commit adds section in HACKING.md to describe the process
of running the e2e tests on a platform-agnostic infrastructure.
@jrvaldes
Add PTR records for platform=none
387fb46
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 3, 2022
Merged
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@selansen
Copy link
Contributor

selansen commented Mar 3, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, selansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-images 387fb46 link true /test okd-images
ci/prow/okd-lint 387fb46 link true /test okd-lint
ci/prow/okd-aws-e2e-operator 387fb46 link true /test okd-aws-e2e-operator
ci/prow/okd-build 387fb46 link true /test okd-build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mansikulkarni96
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2022
@mansikulkarni96
Copy link
Member

/close
in favour of #961

@openshift-ci openshift-ci bot closed this Mar 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2022

@mansikulkarni96: Closed this PR.

In response to this:

/close
in favour of #961

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@selansen selansen Awaiting requested review from selansen

Assignees

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @mansikulkarni96 @selansen @openshift-bot @jrvaldes