Build data adapter examples #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he build system but referenced by documentation)
…ataadapter_examples
… stale/dropped in 4.0, add DataAdapter folder to build and fix syntax to match 4.1 API
|
This PR should take care of the stale source that was detected in #2673, now it compiles and was manually tested. MOTFileAdapter was removed since it was obsoleted earlier in 4.0. |
|
@carmichaelong when you have a chance, can you review? Thanks |
|
Tested the examples locally, LGTM. Thanks! |
|
Thanks @carmichaelong |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2673
Brief summary of changes
Change examples to use 4.1 API and incorporate into build structure so that they stay in sync with API.
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
The Doxygen for this PR can be viewed at http://myosin.sourceforge.net/?C=N;O=D; click the folder whose name is this PR's number.
This change is